From: "Darrick J. Wong" <djwong@kernel.org>
To: Shin Seong-jun <shinsj4653@gmail.com>
Cc: linux-xfs@vger.kernel.org, cem@kernel.org, sandeen@redhat.com,
willy@infradead.org, dchinner@redhat.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] xfs: fix spacing style issues in xfs_alloc.c
Date: Mon, 26 Jan 2026 11:44:44 -0800 [thread overview]
Message-ID: <20260126194444.GZ5945@frogsfrogsfrogs> (raw)
In-Reply-To: <20260123150432.184945-1-shinsj4653@gmail.com>
On Sat, Jan 24, 2026 at 12:04:32AM +0900, Shin Seong-jun wrote:
> Fix checkpatch.pl errors regarding missing spaces around assignment
> operators in xfs_alloc_compute_diff() and xfs_alloc_fixup_trees().
>
> Adhere to the Linux kernel coding style by ensuring spaces are placed
> around the assignment operator '='.
>
> Signed-off-by: Shin Seong-jun <shinsj4653@gmail.com>
Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>
--D
> ---
> fs/xfs/libxfs/xfs_alloc.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/fs/xfs/libxfs/xfs_alloc.c b/fs/xfs/libxfs/xfs_alloc.c
> index ad381c73abc4..c64e6c13f70d 100644
> --- a/fs/xfs/libxfs/xfs_alloc.c
> +++ b/fs/xfs/libxfs/xfs_alloc.c
> @@ -376,8 +376,8 @@ xfs_alloc_compute_diff(
> xfs_agblock_t freeend; /* end of freespace extent */
> xfs_agblock_t newbno1; /* return block number */
> xfs_agblock_t newbno2; /* other new block number */
> - xfs_extlen_t newlen1=0; /* length with newbno1 */
> - xfs_extlen_t newlen2=0; /* length with newbno2 */
> + xfs_extlen_t newlen1 = 0; /* length with newbno1 */
> + xfs_extlen_t newlen2 = 0; /* length with newbno2 */
> xfs_agblock_t wantend; /* end of target extent */
> bool userdata = datatype & XFS_ALLOC_USERDATA;
>
> @@ -577,8 +577,8 @@ xfs_alloc_fixup_trees(
> int i; /* operation results */
> xfs_agblock_t nfbno1; /* first new free startblock */
> xfs_agblock_t nfbno2; /* second new free startblock */
> - xfs_extlen_t nflen1=0; /* first new free length */
> - xfs_extlen_t nflen2=0; /* second new free length */
> + xfs_extlen_t nflen1 = 0; /* first new free length */
> + xfs_extlen_t nflen2 = 0; /* second new free length */
> struct xfs_mount *mp;
> bool fixup_longest = false;
>
> --
> 2.47.3
>
>
next prev parent reply other threads:[~2026-01-26 19:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-23 15:04 [PATCH] xfs: fix spacing style issues in xfs_alloc.c Shin Seong-jun
2026-01-26 19:44 ` Darrick J. Wong [this message]
2026-01-29 11:30 ` Carlos Maiolino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260126194444.GZ5945@frogsfrogsfrogs \
--to=djwong@kernel.org \
--cc=cem@kernel.org \
--cc=dchinner@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@redhat.com \
--cc=shinsj4653@gmail.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox