From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B47EF1A3029 for ; Wed, 28 Jan 2026 03:42:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.95.11.211 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769571759; cv=none; b=UgkibaIphw1UcbJet5GlsznPYDNOE1Yqdc8il6HThG51x3bEHT+mSBCHV2127bDgCCH6hTHmf7nKbcpp1zN0cc4xQtZykv6mcvMqxktPGU+f5oJrd3LespfbpkdXlg41NWvq/NuWbfamGVdJOjgDS25wcu3+LW1IcQnYts2WSWY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769571759; c=relaxed/simple; bh=7MrGaCEkdvXfGqLDGY/aTXowRQ6nGmPD4FRNZtfhmdY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=NfFHJCCcE+IQfPwMiGAJcO8qoRKdDf6WMSID0TK5uM5BwCFvY51auwZSsxSyO4WfP6LdHmXr+OV5RD66aIHv9XFxRqFnnAuTE1ZplSRNJJa1KABwYwQpea+nHh/pyn9xyDRns6fBZWa5yRVHgxRVoq7S0jJyxJAuWIVn+lkHZew= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lst.de; spf=pass smtp.mailfrom=lst.de; arc=none smtp.client-ip=213.95.11.211 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lst.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lst.de Received: by verein.lst.de (Postfix, from userid 2407) id EB2EE227A8E; Wed, 28 Jan 2026 04:42:35 +0100 (CET) Date: Wed, 28 Jan 2026 04:42:35 +0100 From: Christoph Hellwig To: "Darrick J. Wong" Cc: Christoph Hellwig , Carlos Maiolino , Hans Holmberg , linux-xfs@vger.kernel.org Subject: Re: [PATCH 02/10] xfs: allocate m_errortag early Message-ID: <20260128034235.GA30989@lst.de> References: <20260127160619.330250-1-hch@lst.de> <20260127160619.330250-3-hch@lst.de> <20260128013259.GB5945@frogsfrogsfrogs> Precedence: bulk X-Mailing-List: linux-xfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260128013259.GB5945@frogsfrogsfrogs> User-Agent: Mutt/1.5.17 (2007-11-01) On Tue, Jan 27, 2026 at 05:32:59PM -0800, Darrick J. Wong wrote: > On Tue, Jan 27, 2026 at 05:05:42PM +0100, Christoph Hellwig wrote: > > Ensure the mount structure always has a valid m_errortag for debug > > builds. This removes the NULL checking from the runtime code, and > > prepares for allowing to set errortags from mount. > > Hrmm. Are you /sure/ you want to allow errortag mount options? > Saying that only because I really hate mount options. Well, if you have any other good idea to add error tags at mount time I'm all ears :)