Re: [PATCH 1/5] include blkzoned.h in platform_defs.h

["Darrick J. Wong" <djwong@kernel.org>]

On Wed, Jan 28, 2026 at 05:32:55AM +0100, Christoph Hellwig wrote:
> We'll need to conditionally add definitions added in later version of
> blkzoned.h soon.  The right place for that is platform_defs.h, which
> means blkzoned.h needs to be included there for cpp trickery to work.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>

I was /almost/ about to get cranky about including blkzoned.h
unconditionally but then I noticed that the header has been in
include/uapi/ since October 2016.

So I guess it won't cause any problems with a current distro release.
Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>

--D

> ---
>  include/platform_defs.h   | 1 +
>  libxfs/xfs_zones.c        | 1 -
>  mdrestore/xfs_mdrestore.c | 1 -
>  mkfs/xfs_mkfs.c           | 1 -
>  repair/zoned.c            | 1 -
>  5 files changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/include/platform_defs.h b/include/platform_defs.h
> index da966490b0f5..1152f0622ccf 100644
> --- a/include/platform_defs.h
> +++ b/include/platform_defs.h
> @@ -24,6 +24,7 @@
>  #include <stdbool.h>
>  #include <libgen.h>
>  #include <urcu.h>
> +#include <linux/blkzoned.h>
>  
>  /* long and pointer must be either 32 bit or 64 bit */
>  #define BITS_PER_LONG (sizeof(long) * CHAR_BIT)
> diff --git a/libxfs/xfs_zones.c b/libxfs/xfs_zones.c
> index 7a81d83f5b3e..c1ad7075329c 100644
> --- a/libxfs/xfs_zones.c
> +++ b/libxfs/xfs_zones.c
> @@ -3,7 +3,6 @@
>   * Copyright (c) 2023-2025 Christoph Hellwig.
>   * Copyright (c) 2024-2025, Western Digital Corporation or its affiliates.
>   */
> -#include <linux/blkzoned.h>
>  #include "libxfs_priv.h"
>  #include "xfs.h"
>  #include "xfs_fs.h"
> diff --git a/mdrestore/xfs_mdrestore.c b/mdrestore/xfs_mdrestore.c
> index b6e8a6196a79..eece58977f97 100644
> --- a/mdrestore/xfs_mdrestore.c
> +++ b/mdrestore/xfs_mdrestore.c
> @@ -8,7 +8,6 @@
>  #include "xfs_metadump.h"
>  #include <libfrog/platform.h>
>  #include "libfrog/div64.h"
> -#include <linux/blkzoned.h>
>  
>  union mdrestore_headers {
>  	__be32				magic;
> diff --git a/mkfs/xfs_mkfs.c b/mkfs/xfs_mkfs.c
> index b34407725f76..46f4faf4de5a 100644
> --- a/mkfs/xfs_mkfs.c
> +++ b/mkfs/xfs_mkfs.c
> @@ -6,7 +6,6 @@
>  #include "libfrog/util.h"
>  #include "libxfs.h"
>  #include <ctype.h>
> -#include <linux/blkzoned.h>
>  #include "libxfs/xfs_zones.h"
>  #include "xfs_multidisk.h"
>  #include "libxcmd.h"
> diff --git a/repair/zoned.c b/repair/zoned.c
> index 206b0158f95f..49cc43984883 100644
> --- a/repair/zoned.c
> +++ b/repair/zoned.c
> @@ -3,7 +3,6 @@
>   * Copyright (c) 2024 Christoph Hellwig.
>   */
>  #include <ctype.h>
> -#include <linux/blkzoned.h>
>  #include "libxfs_priv.h"
>  #include "libxfs.h"
>  #include "xfs_zones.h"
> -- 
> 2.47.3
> 
>