From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0.herbolt.com (mx0.herbolt.com [5.59.97.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 56D0430BB9B for ; Thu, 19 Feb 2026 11:45:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=5.59.97.199 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771501511; cv=none; b=UldliQfpER4PBp4oegTPPRQfIUHKRVkdHGY9HLrPvAHqOmr6D3xk1dYWd/HnCchqnrOgCjU8Lkd229xcNs1XRvTQX02ZgEMaoRBZiqJy7atvMG7k/DU/9/0cM7Oq0+ornGjzxEWqmaV3FPJsfspVHPxsgsshdSEE8Q/KeuMCtpk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771501511; c=relaxed/simple; bh=eE1ky4J6GpPDttWS6GBJmgH7xpKFgiMVQLKevKhYmaw=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=NZ+QUnfVLR6q2XQXQF0SLHQqrfA+SXY/ccSMH++Wj1VokmSqdoQTdRgV45NbGZyej9Z5J7kq80N0dCth5Oi7gR3cGkqHRc2IEAlUExJmn6Oz2v4hE/b7zijSbVuWULoIlVannlyQRTHX70bqDCsSculDshj1YIQmP1nnnO5G5EQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=herbolt.com; spf=pass smtp.mailfrom=herbolt.com; arc=none smtp.client-ip=5.59.97.199 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=herbolt.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=herbolt.com Received: from mx0.herbolt.com (localhost [127.0.0.1]) by mx0.herbolt.com (Postfix) with ESMTP id 880A9180F2E7; Thu, 19 Feb 2026 12:44:56 +0100 (CET) Received: from trufa.intra.herbolt.com.com ([172.168.31.30]) by mx0.herbolt.com with ESMTPSA id 2/CrGrj3lmlSEAkAKEJqOA (envelope-from ); Thu, 19 Feb 2026 12:44:56 +0100 From: Lukas Herbolt To: hch@infradead.org, aalbersh@redhat.com, cem@kernel.org Cc: linux-xfs@vger.kernel.org, Lukas Herbolt Subject: [PATCH 0/1] mkfs.xfs fix sunit size on 512e and 4kN disks. Date: Thu, 19 Feb 2026 12:44:06 +0100 Message-ID: <20260219114405.31521-3-lukas@herbolt.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-xfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Creating of XFS on 4kN or 512e disk result in suboptimal LSU/LSUNIT. As of now we check if the sectorsize is bigger than XLOG_HEADER_SIZE and so we set lsu to blocksize. But we do not check the the size if lsunit can be bigger to fit the disk geometry. It was laready discussed here: - https://lore.kernel.org/linux-xfs/aOX_TzJIxJWWC63x@infradead.org/ but it somehow fell of the plate. Before: modprobe scsi_debug inq_vendor=XFS_TEST physblk_exp=3 sector_size=512 \ opt_xferlen_exp=9 opt_blks=512 dev_size_mb=100 virtual_gb=1000; \ lsblk -tQ 'VENDOR == "XFS_TEST"'; \ mkfs.xfs -f $(lsblk -Q 'VENDOR == "XFS_TEST"' -no path) 2>/dev/null; sleep 1; \ modprobe -r scsi_debug NAME ALIGNMENT MIN-IO OPT-IO PHY-SEC LOG-SEC ROTA SCHED RQ-SIZE RA WSAME sda 0 262144 262144 4096 512 0 bfq 256 512 0B meta-data=/dev/sda isize=512 agcount=32, agsize=8192000 blks = sectsz=4096 attr=2, projid32bit=1 = crc=1 finobt=1, sparse=1, rmapbt=1 = reflink=1 bigtime=1 inobtcount=1 nrext64=1 = exchange=0 data = bsize=4096 blocks=262144000, imaxpct=25 = sunit=64 swidth=64 blks naming =version 2 bsize=4096 ascii-ci=0, ftype=1, parent=0 log =internal log bsize=4096 blocks=128000, version=2 = sectsz=4096 sunit=1 blks, lazy-count=1 ^^^^^^^^^^^^^^ realtime =none extsz=4096 blocks=0, rtextents=0 After: modprobe scsi_debug inq_vendor=XFS_TEST physblk_exp=3 sector_size=512 \ opt_xferlen_exp=9 opt_blks=512 dev_size_mb=100 virtual_gb=1000; \ lsblk -tQ 'VENDOR == "XFS_TEST"'; \ mkfs.xfs -f $(lsblk -Q 'VENDOR == "XFS_TEST"' -no path) 2>/dev/null; sleep 1; \ modprobe -r scsi_debug NAME ALIGNMENT MIN-IO OPT-IO PHY-SEC LOG-SEC ROTA SCHED RQ-SIZE RA WSAME sda 0 262144 262144 4096 512 0 bfq 256 512 0B meta-data=/dev/sda isize=512 agcount=32, agsize=8192000 blks = sectsz=4096 attr=2, projid32bit=1 = crc=1 finobt=1, sparse=1, rmapbt=1 = reflink=1 bigtime=1 inobtcount=1 nrext64=1 = exchange=0 metadir=0 data = bsize=4096 blocks=262144000, imaxpct=25 = sunit=64 swidth=64 blks naming =version 2 bsize=4096 ascii-ci=0, ftype=1, parent=0 log =internal log bsize=4096 blocks=128000, version=2 = sectsz=4096 sunit=64 blks, lazy-count=1 ^^^^^^^^^^^^^^ realtime =none extsz=4096 blocks=0, rtextents=0 = rgcount=0 rgsize=0 extents = zoned=0 start=0 reserved=0 Lukas Herbolt (1): mkfs.xfs fix sunit size on 512e and 4kN disks. mkfs/xfs_mkfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.53.0