Re: [PATCH v3 4/4] xfs: Add comments for usages of some macros.

["Darrick J. Wong" <djwong@kernel.org>]

On Thu, Feb 19, 2026 at 08:16:50PM +0530, Nirjhar Roy (IBM) wrote:
> From: "Nirjhar Roy (IBM)" <nirjhar.roy.lists@gmail.com>
> 
> Add comments explaining when to use XFS_IS_CORRUPT() and ASSERT()
> 
> Reviewed-by: Christoph Hellwig <hch@lst.de>
> Signed-off-by: Nirjhar Roy (IBM) <nirjhar.roy.lists@gmail.com>
> ---
>  fs/xfs/xfs_platform.h | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/fs/xfs/xfs_platform.h b/fs/xfs/xfs_platform.h
> index 1e59bf94d1f2..c9ce0450cf7a 100644
> --- a/fs/xfs/xfs_platform.h
> +++ b/fs/xfs/xfs_platform.h
> @@ -235,6 +235,7 @@ int xfs_rw_bdev(struct block_device *bdev, sector_t sector, unsigned int count,
>  
>  #ifdef XFS_WARN
>  
> +/* Please note that this ASSERT doesn't kill the kernel */

It will if the kernel has panic_on_warn set.

>  #define ASSERT(expr)	\
>  	(likely(expr) ? (void)0 : asswarn(NULL, #expr, __FILE__, __LINE__))
>  
> @@ -245,6 +246,11 @@ int xfs_rw_bdev(struct block_device *bdev, sector_t sector, unsigned int count,
>  #endif /* XFS_WARN */
>  #endif /* DEBUG */
>  
> +/*
> + * Use this to catch metadata corruptions that are not caught by the regular

"...not caught by the block or structure verifiers."

> + * verifiers. The reason is that the verifiers check corruptions only within
> + * the block.

"...only within the scope of the object being verified."

> + */

Other than that, I agree with this comment.

--D

>  #define XFS_IS_CORRUPT(mp, expr)	\
>  	(unlikely(expr) ? xfs_corruption_error(#expr, XFS_ERRLEVEL_LOW, (mp), \
>  					       NULL, 0, __FILE__, __LINE__, \
> -- 
> 2.43.5
> 
>