From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6E41A336EDB for ; Thu, 19 Feb 2026 15:57:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771516651; cv=none; b=P6efDe+TILax9BJijoX7j1nAKN4bxHl6MYt0LqVxQg7xxxBAcYcgwOrqXSOdQEVDcITcLefydAu8Q+F6CzPgkm2KgOoRJhvH0KjQpzEmxfeUKiN901E5Zp3XYVoOsvSCx1CafTxpfuUOVMuBgnk46e23/uEpZKgPCULesPe5jvQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771516651; c=relaxed/simple; bh=xB40SY9cFcykUPbiCoJz4stZbW8RmVpJkj6fmwWI92c=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=I5gwMg+xfOOqAVk+9d2n07dB7TnHX8edVdiwUh18jwLwn/ovK1LKIQCdPBmhjuQGrL8zjlT+FA2aK/YxvX3AF8TCs8CyhbIzd4Y5GgI24+QAYe8WvvB3nTX9xRDTK53NFljQj4YhT5EHYmRdYHO/5OHMVTNKg19zs/2Xsr8xxNA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=gwqO8tFS; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="gwqO8tFS" Received: by smtp.kernel.org (Postfix) with ESMTPSA id F4224C4CEF7; Thu, 19 Feb 2026 15:57:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1771516651; bh=xB40SY9cFcykUPbiCoJz4stZbW8RmVpJkj6fmwWI92c=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=gwqO8tFSrbRIYT9UF8MrKjQ57X9GYahSq6kGdjw7yw9jBLS/uyqo+zcMBSHxl/ULJ uOSiTVKdMC1/BAqSyZmPksmBH9Am8GW8GncTvCho8ydjC5zuj1/2anhrQoCHIHwFBv LJ6UN+EOIbCmgAH8clFS/Jt0k0djU+LIrJlYDrQkv6Q/TpeWV08XGmZqCa/uJHp/ut cLorwIMFAoNWWBm3H3QvRzwPUPQsYdsjyXGLVWUQ/zmXcNbvTdSURv6sVJ9XjZGqi8 dJ5K5afmRLiUApfxdCiQr3Q0q/RuOzc12iD8RfVymA5JlOkXJqcmMTZOcN54OBUVFS pvbK1fjN1UNGQ== Date: Thu, 19 Feb 2026 07:57:30 -0800 From: "Darrick J. Wong" To: "Nirjhar Roy (IBM)" Cc: hch@infradead.org, cem@kernel.org, linux-xfs@vger.kernel.org, ritesh.list@gmail.com, ojaswin@linux.ibm.com, nirjhar.roy.lists@gmail.com Subject: Re: [PATCH v3 2/4] xfs: Add a comment in xfs_log_sb() Message-ID: <20260219155730.GI6490@frogsfrogsfrogs> References: <54eccbea06953a46f37c376814a9a85539231a25.1771512159.git.nirjhar.roy.lists@gmail.com> Precedence: bulk X-Mailing-List: linux-xfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <54eccbea06953a46f37c376814a9a85539231a25.1771512159.git.nirjhar.roy.lists@gmail.com> On Thu, Feb 19, 2026 at 08:16:48PM +0530, Nirjhar Roy (IBM) wrote: > From: "Nirjhar Roy (IBM)" > > Add a comment explaining why the sb_frextents are updated outside the > if (xfs_has_lazycount(mp) check even though it is a lazycounter. > RT groups are supported only in v5 filesystems which always have > lazycounter enabled - so putting it inside the if(xfs_has_lazycount(mp) > check is redundant. > > Suggested-by: Christoph Hellwig > Reviewed-by: Christoph Hellwig > Signed-off-by: Nirjhar Roy (IBM) Reviewed-by: "Darrick J. Wong" --D > --- > fs/xfs/libxfs/xfs_sb.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/fs/xfs/libxfs/xfs_sb.c b/fs/xfs/libxfs/xfs_sb.c > index 38d16fe1f6d8..47322adb7690 100644 > --- a/fs/xfs/libxfs/xfs_sb.c > +++ b/fs/xfs/libxfs/xfs_sb.c > @@ -1347,6 +1347,9 @@ xfs_log_sb( > * feature was introduced. This counter can go negative due to the way > * we handle nearly-lockless reservations, so we must use the _positive > * variant here to avoid writing out nonsense frextents. > + * > + * RT groups are only supported on v5 file systems, which always > + * have lazy SB counters. > */ > if (xfs_has_rtgroups(mp) && !xfs_has_zoned(mp)) { > mp->m_sb.sb_frextents = > -- > 2.43.5 > >