From: "Darrick J. Wong" <djwong@kernel.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: cem@kernel.org, pankaj.raghav@linux.dev, linux-xfs@vger.kernel.org
Subject: Re: [PATCH 4/6] xfs: fix potential pointer access race in xfs_healthmon_get
Date: Thu, 19 Feb 2026 13:52:00 -0800 [thread overview]
Message-ID: <20260219215200.GR6490@frogsfrogsfrogs> (raw)
In-Reply-To: <aZaxI4PzJKqUc7a_@infradead.org>
On Wed, Feb 18, 2026 at 10:43:47PM -0800, Christoph Hellwig wrote:
> On Wed, Feb 18, 2026 at 10:01:45PM -0800, Darrick J. Wong wrote:
> >
> > - XFS_M((struct super_block *)hm->mount_cookie)->m_healthmon = NULL;
> > + rcu_assign_pointer(XFS_M(
> > + (struct super_block *)hm->mount_cookie)->m_healthmon,
> > + NULL);
>
> Just a nitpick, but factoring the cookie to sb thing into a helper
> or at least separate assignment would really clean this up.
Ok, I'll do that.
mp = XFS_M((struct super_block *)hm->mount_cookie);
rcu_assign_pointer(mp->m_healthmon, NULL);
> Otherwise looks good:
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
Thanks for the reviews!
--D
next prev parent reply other threads:[~2026-02-19 21:52 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-19 6:00 [PATCHSET 1/2] xfs: bug fixes for 7.0 Darrick J. Wong
2026-02-19 6:00 ` [PATCH 1/6] xfs: fix copy-paste error in previous fix Darrick J. Wong
2026-02-19 6:41 ` Christoph Hellwig
2026-02-19 12:56 ` Carlos Maiolino
2026-02-19 6:01 ` [PATCH 2/6] xfs: fix xfs_group release bug in xfs_verify_report_losses Darrick J. Wong
2026-02-19 6:41 ` Christoph Hellwig
2026-02-19 12:57 ` Carlos Maiolino
2026-02-19 6:01 ` [PATCH 3/6] " Darrick J. Wong
2026-02-19 6:42 ` Christoph Hellwig
2026-02-19 13:02 ` Carlos Maiolino
2026-02-19 21:48 ` Darrick J. Wong
2026-02-19 6:01 ` [PATCH 4/6] xfs: fix potential pointer access race in xfs_healthmon_get Darrick J. Wong
2026-02-19 6:43 ` Christoph Hellwig
2026-02-19 13:09 ` Carlos Maiolino
2026-02-19 21:52 ` Darrick J. Wong [this message]
2026-02-19 13:15 ` Pankaj Raghav
2026-02-19 6:02 ` [PATCH 5/6] xfs: don't report metadata inodes to fserror Darrick J. Wong
2026-02-19 6:44 ` Christoph Hellwig
2026-02-19 13:11 ` Carlos Maiolino
2026-02-19 6:02 ` [PATCH 6/6] xfs: don't report half-built " Darrick J. Wong
2026-02-19 6:44 ` Christoph Hellwig
2026-02-19 13:21 ` Carlos Maiolino
2026-02-19 22:02 ` Darrick J. Wong
2026-02-24 11:39 ` Carlos Maiolino
2026-02-24 19:40 ` Darrick J. Wong
-- strict thread matches above, loose matches on Subject: below --
2026-02-20 1:00 [PATCHSET v2 1/2] xfs: bug fixes for 7.0 Darrick J. Wong
2026-02-20 1:01 ` [PATCH 4/6] xfs: fix potential pointer access race in xfs_healthmon_get Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260219215200.GR6490@frogsfrogsfrogs \
--to=djwong@kernel.org \
--cc=cem@kernel.org \
--cc=hch@infradead.org \
--cc=linux-xfs@vger.kernel.org \
--cc=pankaj.raghav@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox