From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>, Christian Brauner <brauner@kernel.org>
Cc: "Darrick J. Wong" <djwong@kernel.org>,
Carlos Maiolino <cem@kernel.org>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Anuj Gupta <anuj20.g@samsung.com>,
Kanchan Joshi <joshi.k@samsung.com>,
Konstantin Komarov <almaz.alexandrovich@paragon-software.com>,
ntfs3@lists.linux.dev, linux-block@vger.kernel.org,
nvdimm@lists.linux.dev, linux-fsdevel@vger.kernel.org,
linux-xfs@vger.kernel.org
Subject: [PATCH 14/16] iomap: support ioends for buffered reads
Date: Mon, 23 Feb 2026 05:20:14 -0800 [thread overview]
Message-ID: <20260223132021.292832-15-hch@lst.de> (raw)
In-Reply-To: <20260223132021.292832-1-hch@lst.de>
Support using the ioend structure to defer I/O completion for
buffered reads by calling into the buffered read I/O completion
handler from iomap_finish_ioend.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>
Tested-by: Anuj Gupta <anuj20.g@samsung.com>
---
fs/iomap/bio.c | 19 ++++++++++++++++---
fs/iomap/internal.h | 1 +
fs/iomap/ioend.c | 8 +++++---
3 files changed, 22 insertions(+), 6 deletions(-)
diff --git a/fs/iomap/bio.c b/fs/iomap/bio.c
index 259a2bf95a43..b4de67bdd513 100644
--- a/fs/iomap/bio.c
+++ b/fs/iomap/bio.c
@@ -8,14 +8,27 @@
#include "internal.h"
#include "trace.h"
-static void iomap_read_end_io(struct bio *bio)
+static u32 __iomap_read_end_io(struct bio *bio, int error)
{
- int error = blk_status_to_errno(bio->bi_status);
struct folio_iter fi;
+ u32 folio_count = 0;
- bio_for_each_folio_all(fi, bio)
+ bio_for_each_folio_all(fi, bio) {
iomap_finish_folio_read(fi.folio, fi.offset, fi.length, error);
+ folio_count++;
+ }
bio_put(bio);
+ return folio_count;
+}
+
+static void iomap_read_end_io(struct bio *bio)
+{
+ __iomap_read_end_io(bio, blk_status_to_errno(bio->bi_status));
+}
+
+u32 iomap_finish_ioend_buffered_read(struct iomap_ioend *ioend)
+{
+ return __iomap_read_end_io(&ioend->io_bio, ioend->io_error);
}
static void iomap_bio_submit_read(const struct iomap_iter *iter,
diff --git a/fs/iomap/internal.h b/fs/iomap/internal.h
index 3a4e4aad2bd1..b39dbc17e3f0 100644
--- a/fs/iomap/internal.h
+++ b/fs/iomap/internal.h
@@ -4,6 +4,7 @@
#define IOEND_BATCH_SIZE 4096
+u32 iomap_finish_ioend_buffered_read(struct iomap_ioend *ioend);
u32 iomap_finish_ioend_direct(struct iomap_ioend *ioend);
#ifdef CONFIG_BLOCK
diff --git a/fs/iomap/ioend.c b/fs/iomap/ioend.c
index e4d57cb969f1..c6b6cd0f2fdd 100644
--- a/fs/iomap/ioend.c
+++ b/fs/iomap/ioend.c
@@ -37,7 +37,7 @@ EXPORT_SYMBOL_GPL(iomap_init_ioend);
* state, release holds on bios, and finally free up memory. Do not use the
* ioend after this.
*/
-static u32 iomap_finish_ioend_buffered(struct iomap_ioend *ioend)
+static u32 iomap_finish_ioend_buffered_write(struct iomap_ioend *ioend)
{
struct inode *inode = ioend->io_inode;
struct bio *bio = &ioend->io_bio;
@@ -74,7 +74,7 @@ static void ioend_writeback_end_bio(struct bio *bio)
struct iomap_ioend *ioend = iomap_ioend_from_bio(bio);
ioend->io_error = blk_status_to_errno(bio->bi_status);
- iomap_finish_ioend_buffered(ioend);
+ iomap_finish_ioend_buffered_write(ioend);
}
/*
@@ -266,7 +266,9 @@ static u32 iomap_finish_ioend(struct iomap_ioend *ioend, int error)
return 0;
if (ioend->io_flags & IOMAP_IOEND_DIRECT)
return iomap_finish_ioend_direct(ioend);
- return iomap_finish_ioend_buffered(ioend);
+ if (bio_op(&ioend->io_bio) == REQ_OP_READ)
+ return iomap_finish_ioend_buffered_read(ioend);
+ return iomap_finish_ioend_buffered_write(ioend);
}
/*
--
2.47.3
next prev parent reply other threads:[~2026-02-23 13:23 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-23 13:20 support file system generated / verified integrity information v4 Christoph Hellwig
2026-02-23 13:20 ` [PATCH 01/16] block: factor out a bio_integrity_action helper Christoph Hellwig
2026-02-23 13:20 ` [PATCH 02/16] block: factor out a bio_integrity_setup_default helper Christoph Hellwig
2026-02-23 13:20 ` [PATCH 03/16] block: add a bdev_has_integrity_csum helper Christoph Hellwig
2026-02-23 13:20 ` [PATCH 04/16] block: prepare generation / verification helpers for fs usage Christoph Hellwig
2026-02-23 13:20 ` [PATCH 05/16] block: make max_integrity_io_size public Christoph Hellwig
2026-02-23 13:20 ` [PATCH 06/16] block: add fs_bio_integrity helpers Christoph Hellwig
2026-02-23 13:20 ` [PATCH 07/16] block: pass a maxlen argument to bio_iov_iter_bounce Christoph Hellwig
2026-02-23 13:20 ` [PATCH 08/16] iomap: refactor iomap_bio_read_folio_range Christoph Hellwig
2026-02-23 13:20 ` [PATCH 09/16] iomap: pass the iomap_iter to ->submit_read Christoph Hellwig
2026-02-23 13:20 ` [PATCH 10/16] iomap: only call into ->submit_read when there is a read_ctx Christoph Hellwig
2026-02-23 13:20 ` [PATCH 11/16] iomap: allow file systems to hook into buffered read bio submission Christoph Hellwig
2026-02-23 13:20 ` [PATCH 12/16] ntfs3: remove copy and pasted iomap code Christoph Hellwig
2026-02-23 16:27 ` Darrick J. Wong
2026-02-27 13:46 ` Konstantin Komarov
2026-03-03 15:21 ` Christoph Hellwig
2026-03-04 9:57 ` Konstantin Komarov
2026-02-23 13:20 ` [PATCH 13/16] iomap: add a bioset pointer to iomap_read_folio_ops Christoph Hellwig
2026-02-23 13:20 ` Christoph Hellwig [this message]
2026-02-23 13:20 ` [PATCH 15/16] iomap: support T10 protection information Christoph Hellwig
2026-02-23 13:20 ` [PATCH 16/16] xfs: " Christoph Hellwig
2026-03-02 10:11 ` support file system generated / verified integrity information v4 Christian Brauner
2026-03-02 13:48 ` Christoph Hellwig
2026-03-04 12:55 ` Christian Brauner
2026-03-09 14:52 ` (subset) " Jens Axboe
2026-03-10 10:16 ` Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260223132021.292832-15-hch@lst.de \
--to=hch@lst.de \
--cc=almaz.alexandrovich@paragon-software.com \
--cc=anuj20.g@samsung.com \
--cc=axboe@kernel.dk \
--cc=brauner@kernel.org \
--cc=cem@kernel.org \
--cc=djwong@kernel.org \
--cc=joshi.k@samsung.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=ntfs3@lists.linux.dev \
--cc=nvdimm@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox