[PATCH 4/5] xfsrestore: remove failing assert from noref_elim_recurse

[Donald Douwsma <ddouwsma@redhat.com>]

We are getting reports from the field where cumulative restores are
aborting due due to a failing assertion.

  xfsrestore: tree.c:1421: noref_elim_recurse: Assertion 'isrealpr' failed

This appears to be caused by a rename within the tree between restore
levels, or a combination of modifications occurring during dump.
Fixing it will likely require changes in noref_elim_recurse and
tree_post, to ensure elements of the tree are created for these edge
conditions. Given the state of xfsdump this is a bit risky for
maintenance streams.

While current builds have assert(3) active, remove this one allowing
xfsrestore to continue, warning on failing renames for directory nodes
that haven't been created. Once the full tree is built referenced
directories will end up in the orphanage allowing for user recovery.

Signed-off-by: Donald Douwsma <ddouwsma@redhat.com>
---
 restore/tree.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/restore/tree.c b/restore/tree.c
index bf89c6a..81666ac 100644
--- a/restore/tree.c
+++ b/restore/tree.c
@@ -1404,12 +1404,13 @@ noref_elim_recurse(nh_t parh,
 				Node_free(&cldh);
 			}
 
+			/* Process renames for directories that have been created.
+			 */
 			if (isrenamepr) {
 				nrh_t nrh;
 				node_t *renamep;
 
 				assert(isrefpr);
-				assert(isrealpr);
 				ok = Node2path(cldh,
 						path1,
 						_("tmp dir rename src"));
-- 
2.47.3