From: "Darrick J. Wong" <djwong@kernel.org>
To: Damien Le Moal <dlemoal@kernel.org>
Cc: linux-xfs@vger.kernel.org, Carlos Maiolino <cem@kernel.org>
Subject: Re: [PATCH] xfs: remove scratch field from struct xfs_gc_bio
Date: Wed, 25 Feb 2026 21:21:15 -0800 [thread overview]
Message-ID: <20260226052115.GD13853@frogsfrogsfrogs> (raw)
In-Reply-To: <20260225224646.2103434-1-dlemoal@kernel.org>
On Thu, Feb 26, 2026 at 07:46:46AM +0900, Damien Le Moal wrote:
> The scratch field in struct xfs_gc_bio is unused. Remove it.
>
> Fixes: 102f444b57b3 ("xfs: rework zone GC buffer management")
> Signed-off-by: Damien Le Moal <dlemoal@kernel.org>
Looks good to me and assuming the bots don't scream,
Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>
--D
> ---
> fs/xfs/xfs_zone_gc.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/fs/xfs/xfs_zone_gc.c b/fs/xfs/xfs_zone_gc.c
> index 48c6cf584447..d78e29cdcc45 100644
> --- a/fs/xfs/xfs_zone_gc.c
> +++ b/fs/xfs/xfs_zone_gc.c
> @@ -96,7 +96,6 @@ struct xfs_gc_bio {
> */
> xfs_fsblock_t old_startblock;
> xfs_daddr_t new_daddr;
> - struct xfs_zone_scratch *scratch;
>
> /* Are we writing to a sequential write required zone? */
> bool is_seq;
> @@ -779,7 +778,6 @@ xfs_zone_gc_split_write(
> ihold(VFS_I(chunk->ip));
> split_chunk->ip = chunk->ip;
> split_chunk->is_seq = chunk->is_seq;
> - split_chunk->scratch = chunk->scratch;
> split_chunk->offset = chunk->offset;
> split_chunk->len = split_len;
> split_chunk->old_startblock = chunk->old_startblock;
> --
> 2.53.0
>
>
next prev parent reply other threads:[~2026-02-26 5:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-25 22:46 [PATCH] xfs: remove scratch field from struct xfs_gc_bio Damien Le Moal
2026-02-26 5:21 ` Darrick J. Wong [this message]
2026-02-26 15:31 ` Christoph Hellwig
2026-02-26 15:56 ` Carlos Maiolino
2026-03-05 9:48 ` Carlos Maiolino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260226052115.GD13853@frogsfrogsfrogs \
--to=djwong@kernel.org \
--cc=cem@kernel.org \
--cc=dlemoal@kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox