From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F00791946C8 for ; Thu, 26 Feb 2026 05:21:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772083276; cv=none; b=Krty6JeL0F3K9tLsr1aE0D7ZFIWwkQeRRYk+vjMeMFNVlPLUuYwE5LIBTgBm2XNLCKYWP7Np3uY6yQr7Jg3Hx9zWSUUB3COvEwz+jnMsQzfckBZ/vGLCrNUxgsSiBkNBVSb1iLef8AonO49OkVi6l5jcCAF8L9Mw7A/Iobh0/HE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772083276; c=relaxed/simple; bh=Z71bM/qwQXIVOG+hKusdTmuk4XaC2SBTguRPDmjDL4Y=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=oJadSgvPabGTalOPir3/5/hSUDtGO0dsKKQPfB6be0toSLsjxt1BU9zSZexO8cxdWajupzmtJfvd2+pbEGZ18MfK1BRtvIi+/0cOHumoTsMUSp9Y2p2XG59coS1JRXa/M4zZmji4+b2bTI0iQUqDByjiN+/4ejAdUIfhqr1/o/M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ZcnxAooQ; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ZcnxAooQ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9D606C19422; Thu, 26 Feb 2026 05:21:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772083275; bh=Z71bM/qwQXIVOG+hKusdTmuk4XaC2SBTguRPDmjDL4Y=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ZcnxAooQEnXrJj8P9nIUweQhExmrpVgrUKIi8+IBN4+uXWW6PtaqjG1vrr8dMeMPM cbcw0KylqkYO9qPZsPmrGFDW+Eq93+u7wcx2oifSang0luvvn3B7G+riXWngeLQEVZ aq9oopb/8b/CX4inIBO6evpBRH+54HdzXZffFspbV73FDq58udFXmGY6pN009OaNTV z0MS4GX/BScIzcnG7pHsTCUTRC0cMeDtsbxm6Dz9zlDhXEWA6qKJqV3ubzZW4k4unh +DF/mgHSIiwh87pXFcZaKdSYTcnu5CiKMxl0L/6sv3ECauUNlR75DYNASQd9wyBD7N 0gibbG9iVD7nw== Date: Wed, 25 Feb 2026 21:21:15 -0800 From: "Darrick J. Wong" To: Damien Le Moal Cc: linux-xfs@vger.kernel.org, Carlos Maiolino Subject: Re: [PATCH] xfs: remove scratch field from struct xfs_gc_bio Message-ID: <20260226052115.GD13853@frogsfrogsfrogs> References: <20260225224646.2103434-1-dlemoal@kernel.org> Precedence: bulk X-Mailing-List: linux-xfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260225224646.2103434-1-dlemoal@kernel.org> On Thu, Feb 26, 2026 at 07:46:46AM +0900, Damien Le Moal wrote: > The scratch field in struct xfs_gc_bio is unused. Remove it. > > Fixes: 102f444b57b3 ("xfs: rework zone GC buffer management") > Signed-off-by: Damien Le Moal Looks good to me and assuming the bots don't scream, Reviewed-by: "Darrick J. Wong" --D > --- > fs/xfs/xfs_zone_gc.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/fs/xfs/xfs_zone_gc.c b/fs/xfs/xfs_zone_gc.c > index 48c6cf584447..d78e29cdcc45 100644 > --- a/fs/xfs/xfs_zone_gc.c > +++ b/fs/xfs/xfs_zone_gc.c > @@ -96,7 +96,6 @@ struct xfs_gc_bio { > */ > xfs_fsblock_t old_startblock; > xfs_daddr_t new_daddr; > - struct xfs_zone_scratch *scratch; > > /* Are we writing to a sequential write required zone? */ > bool is_seq; > @@ -779,7 +778,6 @@ xfs_zone_gc_split_write( > ihold(VFS_I(chunk->ip)); > split_chunk->ip = chunk->ip; > split_chunk->is_seq = chunk->is_seq; > - split_chunk->scratch = chunk->scratch; > split_chunk->offset = chunk->offset; > split_chunk->len = split_len; > split_chunk->old_startblock = chunk->old_startblock; > -- > 2.53.0 > >