From: cem@kernel.org
To: linux-xfs@vger.kernel.org
Cc: hch@lst.de, dlemoal@kernel.org
Subject: [PATCH 4/4] xfs: opencode xfs_zone_record_blocks
Date: Tue, 10 Mar 2026 12:55:07 +0100 [thread overview]
Message-ID: <20260310115555.114197-5-cem@kernel.org> (raw)
In-Reply-To: <20260310115555.114197-1-cem@kernel.org>
From: Carlos Maiolino <cem@kernel.org>
We only have a single caller, no need to keep it in its own function.
Signed-off-by: Carlos Maiolino <cmaiolino@redhat.com>
---
fs/xfs/xfs_zone_alloc.c | 30 ++++++++----------------------
1 file changed, 8 insertions(+), 22 deletions(-)
diff --git a/fs/xfs/xfs_zone_alloc.c b/fs/xfs/xfs_zone_alloc.c
index 97149bfc2512..7d712d5a5ce0 100644
--- a/fs/xfs/xfs_zone_alloc.c
+++ b/fs/xfs/xfs_zone_alloc.c
@@ -201,27 +201,6 @@ xfs_zone_inc_written(
xfs_open_zone_mark_full(oz);
}
-static void
-xfs_zone_record_blocks(
- struct xfs_trans *tp,
- struct xfs_open_zone *oz,
- xfs_fsblock_t fsbno,
- xfs_filblks_t len)
-{
- struct xfs_mount *mp = tp->t_mountp;
- struct xfs_rtgroup *rtg = oz->oz_rtg;
- struct xfs_inode *rmapip = rtg_rmap(rtg);
-
- trace_xfs_zone_record_blocks(oz, xfs_rtb_to_rgbno(mp, fsbno), len);
-
- xfs_rtgroup_lock(rtg, XFS_RTGLOCK_RMAP);
- xfs_rtgroup_trans_join(tp, rtg, XFS_RTGLOCK_RMAP);
- rmapip->i_used_blocks += len;
- ASSERT(rmapip->i_used_blocks <= rtg_blocks(rtg));
- xfs_zone_inc_written(oz, len);
- xfs_trans_log_inode(tp, rmapip, XFS_ILOG_CORE);
-}
-
/*
* Called for blocks that have been written to disk, but not actually linked to
* an inode, which can happen when garbage collection races with user data
@@ -252,6 +231,8 @@ xfs_zoned_map_extent(
xfs_fsblock_t old_startblock)
{
struct xfs_bmbt_irec data;
+ struct xfs_rtgroup *rtg = oz->oz_rtg;
+ struct xfs_inode *rmapip = rtg_rmap(rtg);
int nmaps = 1;
int error;
@@ -310,7 +291,12 @@ xfs_zoned_map_extent(
}
}
- xfs_zone_record_blocks(tp, oz, new->br_startblock, new->br_blockcount);
+ xfs_rtgroup_lock(rtg, XFS_RTGLOCK_RMAP);
+ xfs_rtgroup_trans_join(tp, rtg, XFS_RTGLOCK_RMAP);
+ rmapip->i_used_blocks += new->br_blockcount;
+ ASSERT(rmapip->i_used_blocks <= rtg_blocks(rtg));
+ xfs_zone_inc_written(oz, new->br_blockcount);
+ xfs_trans_log_inode(tp, rmapip, XFS_ILOG_CORE);
/* Map the new blocks into the data fork. */
xfs_bmap_map_extent(tp, ip, XFS_DATA_FORK, new);
--
2.53.0
next prev parent reply other threads:[~2026-03-10 11:56 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-10 11:55 [PATCH 0/4] Zoned device cleanups cem
2026-03-10 11:55 ` [PATCH 1/4] xfs: factor out isize updates from xfs_dio_write_end_io cem
2026-03-10 12:51 ` Damien Le Moal
2026-03-10 12:52 ` Christoph Hellwig
2026-03-10 11:55 ` [PATCH 2/4] xfs: move zoned dio ioend to its own function cem
2026-03-10 12:53 ` Christoph Hellwig
2026-03-10 12:54 ` Damien Le Moal
2026-03-10 11:55 ` [PATCH 3/4] xfs: factor out xfs_zone_inc_written cem
2026-03-10 12:54 ` Christoph Hellwig
2026-03-10 12:55 ` Damien Le Moal
2026-03-10 11:55 ` cem [this message]
2026-03-10 12:54 ` [PATCH 4/4] xfs: opencode xfs_zone_record_blocks Christoph Hellwig
2026-03-10 12:56 ` Damien Le Moal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260310115555.114197-5-cem@kernel.org \
--to=cem@kernel.org \
--cc=dlemoal@kernel.org \
--cc=hch@lst.de \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox