Re: [PATCH 1/4] xfs: factor out isize updates from xfs_dio_write_end_io

[Christoph Hellwig <hch@lst.de>]

On Tue, Mar 10, 2026 at 12:55:04PM +0100, cem@kernel.org wrote:
> +static int
> +xfs_dio_endio_set_isize(
> +	struct inode		*inode,
> +	loff_t			offset,
> +	ssize_t			size)
> +{
> +	struct xfs_inode	*ip = XFS_I(inode);
> +
> +	if (offset + size <= i_size_read(inode))
> +		return 0;
> +
> +	spin_lock(&ip->i_flags_lock);
> +	if (offset + size > i_size_read(inode)) {
> +		i_size_write(inode, offset + size);
> +		spin_unlock(&ip->i_flags_lock);
> +	} else {
> +		spin_unlock(&ip->i_flags_lock);
> +	}
> +
> +	return xfs_setfilesize(ip, offset, size);

This now calls xfs_setfilesize for the case where we don't update
the inode size.  This looks harmless to be, but isn't needed.

This should become something like:

	if (offset + size <= i_size_read(inode)) {
		spin_unlock(&ip->i_flags_lock);
		return 0;
	}
	i_size_write(inode, offset + size);
	spin_unlock(&ip->i_flags_lock);
	return xfs_setfilesize(ip, offset, size);