Re: [PATCH 3/3] xfs: remove owner field from xfs_extent_busy

[Christoph Hellwig <hch@lst.de>]

On Tue, Mar 10, 2026 at 01:33:16PM +0100, cem@kernel.org wrote:
> From: Carlos Maiolino <cem@kernel.org>
> 
> Now that xfs_busy_extents is not embedded into a cil context, we can
> get rid of the owner field.
> 
> The struct will be freed upon a call to xfs_discard_extents(), whether
> at IO completion or by direct calling xfs_discard_endio_work().
> 
> What reamains is xlog_cil_commited now being responsible for freeing
> the context itself.
> 
> Worth mentioning that the busy extents still need to be manually freed
> during filesystem shutdown via xlog_cil_destroy() if there is a
> remaining context there.
> 
> Also, xlog_cil_committed() now unconditionally calls xfs_discard_extents.
> This seems safe because it can handle an empty list, and as a bonus,
> it will call xfs_discard_endio_work() for such case, without any extra
> wiring needed to free the busy extents list in case it is empty.
> xfs_discard_endio_work() is also able to properly handle the empty list.

Looking at this series, it feels almost like this should be mostly
merged with the previous patch, with a small caveat:

>  
>  	xlog_cil_free_logvec(&ctx->lv_chain);
>  
> -	if (!list_empty(&ctx->busy_extents->extent_list)) {
> -		ctx->busy_extents->owner = ctx;
> -		xfs_discard_extents(mp, ctx->busy_extents);
> -		return;
> -	}
> -
> -	xfs_busy_extents_free(ctx->busy_extents);
> +	xfs_discard_extents(mp, busy_extents);

I'd probably split this part out as it really neeѕs an explanation
and seems to be something taking advantage of the new dynamic
allocation scheme.