From: "Darrick J. Wong" <djwong@kernel.org>
To: zlang@redhat.com
Cc: fstests@vger.kernel.org, linux-xfs@vger.kernel.org
Subject: [PATCH] xfs/62[3-8]: require XFS_SCRUB_PROG
Date: Tue, 10 Mar 2026 21:14:43 -0700 [thread overview]
Message-ID: <20260311041443.GC6023@frogsfrogsfrogs> (raw)
From: Darrick J. Wong <djwong@kernel.org>
QA reports that xfs/62[3-8] fail because they didn't install
xfsprogs-xfs_scrub package and this test requires xfs_scrub(8).
Add the missing _require call, and update the README so that anyone
running fstests on RHEL/Fedora actually get all the necessary
components to do a full test of XFS.
Cc: <fstests@vger.kernel.org> # v2024.06.27
Fixes: 4de8fd7860a2bb ("scrub: test correction of directory tree corruptions")
Signed-off-by: "Darrick J. Wong" <djwong@kernel.org>
---
README | 2 +-
tests/xfs/623 | 3 +--
tests/xfs/624 | 3 +--
tests/xfs/625 | 3 +--
tests/xfs/626 | 3 +--
tests/xfs/627 | 3 +--
tests/xfs/628 | 1 +
7 files changed, 7 insertions(+), 11 deletions(-)
diff --git a/README b/README
index 211e273115f08f..36684cc6572d4b 100644
--- a/README
+++ b/README
@@ -126,7 +126,7 @@ Fedora
$ sudo yum install acl attr automake bc dbench dump e2fsprogs fio gawk gcc \
gdbm-devel git indent kernel-devel libacl-devel libaio-devel \
libcap-devel libtool liburing-devel libuuid-devel lvm2 make psmisc \
- python3 quota sed sqlite udftools xfsprogs
+ python3 quota sed sqlite udftools xfsprogs xfsprogs-xfs_scrub
2. Install packages for the filesystem(s) being tested:
diff --git a/tests/xfs/623 b/tests/xfs/623
index aff3f903660fa7..7f79ccbcbf7f14 100755
--- a/tests/xfs/623
+++ b/tests/xfs/623
@@ -16,8 +16,7 @@ _begin_fstest auto online_repair
. ./common/fuzzy
. ./common/populate
-
-# Modify as appropriate.
+_require_scrub
_require_xfs_db_command "link"
_require_xfs_db_command "unlink"
_require_scratch
diff --git a/tests/xfs/624 b/tests/xfs/624
index e63cfcc6e7ba82..09a922c8d18c8a 100755
--- a/tests/xfs/624
+++ b/tests/xfs/624
@@ -16,8 +16,7 @@ _begin_fstest auto online_repair
. ./common/fuzzy
. ./common/populate
-
-# Modify as appropriate.
+_require_scrub
_require_xfs_db_command "link"
_require_xfs_db_command "unlink"
_require_scratch
diff --git a/tests/xfs/625 b/tests/xfs/625
index 23013f195c9e7f..2654216b67aa11 100755
--- a/tests/xfs/625
+++ b/tests/xfs/625
@@ -16,8 +16,7 @@ _begin_fstest auto online_repair
. ./common/fuzzy
. ./common/populate
-
-# Modify as appropriate.
+_require_scrub
_require_xfs_db_command "link"
_require_xfs_db_command "unlink"
_require_scratch
diff --git a/tests/xfs/626 b/tests/xfs/626
index c424819cede6e1..3b4cdca4fe4e24 100755
--- a/tests/xfs/626
+++ b/tests/xfs/626
@@ -16,8 +16,7 @@ _begin_fstest auto online_repair
. ./common/fuzzy
. ./common/populate
-
-# Modify as appropriate.
+_require_scrub
_require_xfs_db_command "link"
_require_xfs_db_command "unlink"
_require_scratch
diff --git a/tests/xfs/627 b/tests/xfs/627
index 411a7603317058..fc54199b4a95de 100755
--- a/tests/xfs/627
+++ b/tests/xfs/627
@@ -16,8 +16,7 @@ _begin_fstest auto online_repair
. ./common/fuzzy
. ./common/populate
-
-# Modify as appropriate.
+_require_scrub
_require_xfs_db_command "link"
_require_xfs_db_command "unlink"
_require_scratch
diff --git a/tests/xfs/628 b/tests/xfs/628
index c77d67db358983..e003f41999f401 100755
--- a/tests/xfs/628
+++ b/tests/xfs/628
@@ -17,6 +17,7 @@ _begin_fstest scrub fsstress_scrub
. ./common/inject
. ./common/xfs
+_require_scrub
_require_scratch
_require_xfs_stress_scrub
next reply other threads:[~2026-03-11 4:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-11 4:14 Darrick J. Wong [this message]
2026-03-12 7:00 ` [PATCH] xfs/62[3-8]: require XFS_SCRUB_PROG Christoph Hellwig
2026-03-13 17:55 ` Zorro Lang
2026-03-13 23:45 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260311041443.GC6023@frogsfrogsfrogs \
--to=djwong@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=zlang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox