* [PATCH] xfs_io: fix fsmap help
@ 2026-03-11 9:25 Christoph Hellwig
2026-03-11 9:55 ` Andrey Albershteyn
2026-03-11 14:26 ` Darrick J. Wong
0 siblings, 2 replies; 5+ messages in thread
From: Christoph Hellwig @ 2026-03-11 9:25 UTC (permalink / raw)
To: aalbersh; +Cc: linux-xfs
By default fsmap prints the reverse mapping for all devices. Update the
help text to correctly reflect that.
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
io/fsmap.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/io/fsmap.c b/io/fsmap.c
index 005d32e500a0..0182154fee47 100644
--- a/io/fsmap.c
+++ b/io/fsmap.c
@@ -24,7 +24,8 @@ fsmap_help(void)
"\n"
" Prints the block mapping for the filesystem hosting the current file"
"\n"
-" fsmap prints the map of disk blocks used by the whole filesystem.\n"
+" fsmap prints the map of disk blocks used on a given file system filesystem.\n"
+" By default, the blocks for all devices are printed.\n"
" When possible, owner and offset information will be included in the\n"
" space report.\n"
"\n"
@@ -32,7 +33,7 @@ fsmap_help(void)
" extent: major:minor [startblock..endblock]: owner startoffset..endoffset length\n"
" The owner field is either an inode number or a special value.\n"
" All the file offsets and disk blocks are in units of 512-byte blocks.\n"
-" -d -- query only the data device (default).\n"
+" -d -- query only the data device.\n"
" -l -- query only the log device.\n"
" -r -- query only the realtime device.\n"
" -n -- query n extents at a time.\n"
--
2.47.3
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] xfs_io: fix fsmap help
2026-03-11 9:25 [PATCH] xfs_io: fix fsmap help Christoph Hellwig
@ 2026-03-11 9:55 ` Andrey Albershteyn
2026-03-11 14:26 ` Darrick J. Wong
1 sibling, 0 replies; 5+ messages in thread
From: Andrey Albershteyn @ 2026-03-11 9:55 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: aalbersh, linux-xfs
On 2026-03-11 10:25:00, Christoph Hellwig wrote:
> By default fsmap prints the reverse mapping for all devices. Update the
> help text to correctly reflect that.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
LGTM
Reviewed-by: Andrey Albershteyn <aalbersh@kernel.org>
--
- Andrey
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] xfs_io: fix fsmap help
2026-03-11 9:25 [PATCH] xfs_io: fix fsmap help Christoph Hellwig
2026-03-11 9:55 ` Andrey Albershteyn
@ 2026-03-11 14:26 ` Darrick J. Wong
1 sibling, 0 replies; 5+ messages in thread
From: Darrick J. Wong @ 2026-03-11 14:26 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: aalbersh, linux-xfs
On Wed, Mar 11, 2026 at 10:25:00AM +0100, Christoph Hellwig wrote:
> By default fsmap prints the reverse mapping for all devices. Update the
> help text to correctly reflect that.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
> io/fsmap.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/io/fsmap.c b/io/fsmap.c
> index 005d32e500a0..0182154fee47 100644
> --- a/io/fsmap.c
> +++ b/io/fsmap.c
> @@ -24,7 +24,8 @@ fsmap_help(void)
> "\n"
> " Prints the block mapping for the filesystem hosting the current file"
> "\n"
> -" fsmap prints the map of disk blocks used by the whole filesystem.\n"
> +" fsmap prints the map of disk blocks used on a given file system filesystem.\n"
redundant ^^^^^^^^^^^
Otherwise this reads ok to me.
--D
> +" By default, the blocks for all devices are printed.\n"
> " When possible, owner and offset information will be included in the\n"
> " space report.\n"
> "\n"
> @@ -32,7 +33,7 @@ fsmap_help(void)
> " extent: major:minor [startblock..endblock]: owner startoffset..endoffset length\n"
> " The owner field is either an inode number or a special value.\n"
> " All the file offsets and disk blocks are in units of 512-byte blocks.\n"
> -" -d -- query only the data device (default).\n"
> +" -d -- query only the data device.\n"
> " -l -- query only the log device.\n"
> " -r -- query only the realtime device.\n"
> " -n -- query n extents at a time.\n"
> --
> 2.47.3
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] xfs_io: fix fsmap help
@ 2026-03-12 6:59 Christoph Hellwig
2026-03-12 14:24 ` Darrick J. Wong
0 siblings, 1 reply; 5+ messages in thread
From: Christoph Hellwig @ 2026-03-12 6:59 UTC (permalink / raw)
To: aalbersh; +Cc: djwong, linux-xfs
By default fsmap prints the reverse mapping for all devices. Update the
help text to correctly reflect that.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Andrey Albershteyn <aalbersh@kernel.org>
---
io/fsmap.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/io/fsmap.c b/io/fsmap.c
index 005d32e500a0..83ea24d69175 100644
--- a/io/fsmap.c
+++ b/io/fsmap.c
@@ -24,7 +24,8 @@ fsmap_help(void)
"\n"
" Prints the block mapping for the filesystem hosting the current file"
"\n"
-" fsmap prints the map of disk blocks used by the whole filesystem.\n"
+" fsmap prints the map of disk blocks used on a given filesystem.\n"
+" By default, the blocks for all devices are printed.\n"
" When possible, owner and offset information will be included in the\n"
" space report.\n"
"\n"
@@ -32,7 +33,7 @@ fsmap_help(void)
" extent: major:minor [startblock..endblock]: owner startoffset..endoffset length\n"
" The owner field is either an inode number or a special value.\n"
" All the file offsets and disk blocks are in units of 512-byte blocks.\n"
-" -d -- query only the data device (default).\n"
+" -d -- query only the data device.\n"
" -l -- query only the log device.\n"
" -r -- query only the realtime device.\n"
" -n -- query n extents at a time.\n"
--
2.47.3
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] xfs_io: fix fsmap help
2026-03-12 6:59 Christoph Hellwig
@ 2026-03-12 14:24 ` Darrick J. Wong
0 siblings, 0 replies; 5+ messages in thread
From: Darrick J. Wong @ 2026-03-12 14:24 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: aalbersh, linux-xfs
On Thu, Mar 12, 2026 at 07:59:36AM +0100, Christoph Hellwig wrote:
> By default fsmap prints the reverse mapping for all devices. Update the
> help text to correctly reflect that.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> Reviewed-by: Andrey Albershteyn <aalbersh@kernel.org>
Looks good now
Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>
--D
> ---
> io/fsmap.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/io/fsmap.c b/io/fsmap.c
> index 005d32e500a0..83ea24d69175 100644
> --- a/io/fsmap.c
> +++ b/io/fsmap.c
> @@ -24,7 +24,8 @@ fsmap_help(void)
> "\n"
> " Prints the block mapping for the filesystem hosting the current file"
> "\n"
> -" fsmap prints the map of disk blocks used by the whole filesystem.\n"
> +" fsmap prints the map of disk blocks used on a given filesystem.\n"
> +" By default, the blocks for all devices are printed.\n"
> " When possible, owner and offset information will be included in the\n"
> " space report.\n"
> "\n"
> @@ -32,7 +33,7 @@ fsmap_help(void)
> " extent: major:minor [startblock..endblock]: owner startoffset..endoffset length\n"
> " The owner field is either an inode number or a special value.\n"
> " All the file offsets and disk blocks are in units of 512-byte blocks.\n"
> -" -d -- query only the data device (default).\n"
> +" -d -- query only the data device.\n"
> " -l -- query only the log device.\n"
> " -r -- query only the realtime device.\n"
> " -n -- query n extents at a time.\n"
> --
> 2.47.3
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2026-03-12 14:24 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-11 9:25 [PATCH] xfs_io: fix fsmap help Christoph Hellwig
2026-03-11 9:55 ` Andrey Albershteyn
2026-03-11 14:26 ` Darrick J. Wong
-- strict thread matches above, loose matches on Subject: below --
2026-03-12 6:59 Christoph Hellwig
2026-03-12 14:24 ` Darrick J. Wong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox