From: "Darrick J. Wong" <djwong@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: aalbersh@kernel.org, linux-xfs@vger.kernel.org
Subject: Re: [PATCH] xfs_io: fix fsmap help
Date: Thu, 12 Mar 2026 07:24:23 -0700 [thread overview]
Message-ID: <20260312142423.GH1770774@frogsfrogsfrogs> (raw)
In-Reply-To: <20260312065937.1156721-1-hch@lst.de>
On Thu, Mar 12, 2026 at 07:59:36AM +0100, Christoph Hellwig wrote:
> By default fsmap prints the reverse mapping for all devices. Update the
> help text to correctly reflect that.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> Reviewed-by: Andrey Albershteyn <aalbersh@kernel.org>
Looks good now
Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>
--D
> ---
> io/fsmap.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/io/fsmap.c b/io/fsmap.c
> index 005d32e500a0..83ea24d69175 100644
> --- a/io/fsmap.c
> +++ b/io/fsmap.c
> @@ -24,7 +24,8 @@ fsmap_help(void)
> "\n"
> " Prints the block mapping for the filesystem hosting the current file"
> "\n"
> -" fsmap prints the map of disk blocks used by the whole filesystem.\n"
> +" fsmap prints the map of disk blocks used on a given filesystem.\n"
> +" By default, the blocks for all devices are printed.\n"
> " When possible, owner and offset information will be included in the\n"
> " space report.\n"
> "\n"
> @@ -32,7 +33,7 @@ fsmap_help(void)
> " extent: major:minor [startblock..endblock]: owner startoffset..endoffset length\n"
> " The owner field is either an inode number or a special value.\n"
> " All the file offsets and disk blocks are in units of 512-byte blocks.\n"
> -" -d -- query only the data device (default).\n"
> +" -d -- query only the data device.\n"
> " -l -- query only the log device.\n"
> " -r -- query only the realtime device.\n"
> " -n -- query n extents at a time.\n"
> --
> 2.47.3
>
>
next prev parent reply other threads:[~2026-03-12 14:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-12 6:59 [PATCH] xfs_io: fix fsmap help Christoph Hellwig
2026-03-12 14:24 ` Darrick J. Wong [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-03-11 9:25 Christoph Hellwig
2026-03-11 9:55 ` Andrey Albershteyn
2026-03-11 14:26 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260312142423.GH1770774@frogsfrogsfrogs \
--to=djwong@kernel.org \
--cc=aalbersh@kernel.org \
--cc=hch@lst.de \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox