Linux XFS filesystem development
 help / color / mirror / Atom feed
From: "Darrick J. Wong" <djwong@kernel.org>
To: Wilfred Mallawa <wilfred.opensource@gmail.com>
Cc: Christoph Hellwig <hch@lst.de>,
	Alistair Francis <alistair.francis@wdc.com>,
	Damien Le'Moal <dlemoal@kernel.org>,
	linux-xfs@vger.kernel.org,
	Wilfred Mallawa <wilfred.mallawa@wdc.com>
Subject: Re: [PATCH 3/3] xfs_io: report rg_writepointer in report rg_info()
Date: Thu, 12 Mar 2026 20:28:15 -0700	[thread overview]
Message-ID: <20260313032815.GL1770774@frogsfrogsfrogs> (raw)
In-Reply-To: <20260313002456.3823811-3-wilfred.opensource@gmail.com>

On Fri, Mar 13, 2026 at 10:24:56AM +1000, Wilfred Mallawa wrote:
> From: Wilfred Mallawa <wilfred.mallawa@wdc.com>
> 
> If the XFS_RTGROUP_GEOM_WRITEPOINTER field is set, then print the
> writepointer in struct xfs_rtgroup_geometry.
> 
> Signed-off-by: Wilfred Mallawa <wilfred.mallawa@wdc.com>
> ---
>  io/aginfo.c | 3 +++

Looks good to me!
Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>

--D

>  1 file changed, 3 insertions(+)
> 
> diff --git a/io/aginfo.c b/io/aginfo.c
> index f81986f0d..978f0f3b8 100644
> --- a/io/aginfo.c
> +++ b/io/aginfo.c
> @@ -132,6 +132,9 @@ report_rginfo(
>  	printf(_("Checked: 0x%x\n"),	rgeo.rg_checked);
>  	printf(_("Flags: 0x%x\n"),	rgeo.rg_flags);
>  
> +	if (rgeo.rg_flags & XFS_RTGROUP_GEOM_WRITEPOINTER)
> +		printf(_("Writepointer: 0x%u\n"), rgeo.rg_writepointer);
> +
>  	return 0;
>  }
>  
> -- 
> 2.53.0
> 
> 

  reply	other threads:[~2026-03-13  3:28 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-13  0:24 [PATCH 1/3] xfs: add write pointer to xfs_rtgroup_geometry Wilfred Mallawa
2026-03-13  0:24 ` [PATCH 2/3] man/xfs_rtgroup_geometry: add rg_writepointer field description Wilfred Mallawa
2026-03-13  3:27   ` Darrick J. Wong
2026-03-16  9:04   ` Christoph Hellwig
2026-03-13  0:24 ` [PATCH 3/3] xfs_io: report rg_writepointer in report rg_info() Wilfred Mallawa
2026-03-13  3:28   ` Darrick J. Wong [this message]
2026-03-16  9:04   ` Christoph Hellwig
2026-09-22 12:50 ` [PATCH 1/3] xfs: add write pointer to xfs_rtgroup_geometry Christoph Hellwig
2026-09-22 13:41   ` Carlos Maiolino
2026-09-22 13:45     ` Christoph Hellwig
2026-09-22 14:01     ` Andrey Albershteyn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260313032815.GL1770774@frogsfrogsfrogs \
    --to=djwong@kernel.org \
    --cc=alistair.francis@wdc.com \
    --cc=dlemoal@kernel.org \
    --cc=hch@lst.de \
    --cc=linux-xfs@vger.kernel.org \
    --cc=wilfred.mallawa@wdc.com \
    --cc=wilfred.opensource@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox