Re: [PATCH v2 3/4] xfs: factor out xfs_attr3_leaf_init

["Darrick J. Wong" <djwong@kernel.org>]

On Thu, Mar 12, 2026 at 04:57:59PM +0800, Long Li wrote:
> Factor out wrapper xfs_attr3_leaf_init function, which exported for
> external use.
> 
> Signed-off-by: Long Li <leo.lilong@huawei.com>
> ---
>  fs/xfs/libxfs/xfs_attr_leaf.c | 22 ++++++++++++++++++++++
>  fs/xfs/libxfs/xfs_attr_leaf.h |  3 +++
>  2 files changed, 25 insertions(+)
> 
> diff --git a/fs/xfs/libxfs/xfs_attr_leaf.c b/fs/xfs/libxfs/xfs_attr_leaf.c
> index 47f48ae555c0..96a65141e812 100644
> --- a/fs/xfs/libxfs/xfs_attr_leaf.c
> +++ b/fs/xfs/libxfs/xfs_attr_leaf.c
> @@ -1415,6 +1415,28 @@ xfs_attr3_leaf_create(
>  	return 0;
>  }
>  
> +/*
> + * Create and initialize an empty attr leaf block at blkno, and attach the
> + * buffer to tp.

Not sure why we "create and initialize" here -- there's already a block
mapped at @blkno and we're rewriting it with a leaf header, right?

/*
 * Reinitialize an existing attr fork block as an empty leaf, and
 * attach the buffer to tp.
 */

With that changed,
Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>

--D


> + */
> +int
> +xfs_attr3_leaf_init(
> +	struct xfs_trans	*tp,
> +	struct xfs_inode	*dp,
> +	xfs_dablk_t		blkno)
> +{
> +	struct xfs_buf		*bp = NULL;
> +	struct xfs_da_args	args = {
> +		.trans		= tp,
> +		.dp		= dp,
> +		.owner		= dp->i_ino,
> +		.geo		= dp->i_mount->m_attr_geo,
> +	};
> +
> +	ASSERT(tp != NULL);
> +
> +	return xfs_attr3_leaf_create(&args, blkno, &bp);
> +}
>  /*
>   * Split the leaf node, rebalance, then add the new entry.
>   *
> diff --git a/fs/xfs/libxfs/xfs_attr_leaf.h b/fs/xfs/libxfs/xfs_attr_leaf.h
> index aca46da2bc50..72639efe6ac3 100644
> --- a/fs/xfs/libxfs/xfs_attr_leaf.h
> +++ b/fs/xfs/libxfs/xfs_attr_leaf.h
> @@ -87,6 +87,9 @@ int	xfs_attr3_leaf_list_int(struct xfs_buf *bp,
>  /*
>   * Routines used for shrinking the Btree.
>   */
> +
> +int	xfs_attr3_leaf_init(struct xfs_trans *tp, struct xfs_inode *dp,
> +				xfs_dablk_t blkno);
>  int	xfs_attr3_leaf_toosmall(struct xfs_da_state *state, int *retval);
>  void	xfs_attr3_leaf_unbalance(struct xfs_da_state *state,
>  				       struct xfs_da_state_blk *drop_blk,
> -- 
> 2.39.2
> 
>