From: Damien Le Moal <dlemoal@kernel.org>
To: linux-xfs@vger.kernel.org, Carlos Maiolino <cem@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>, Hans Holmberg <hans.holmberg@wdc.com>
Subject: [PATCH 1/3] xfs: improve xfs_select_zone_nowait()
Date: Sun, 15 Mar 2026 08:55:06 +0900 [thread overview]
Message-ID: <20260314235508.183984-2-dlemoal@kernel.org> (raw)
In-Reply-To: <20260314235508.183984-1-dlemoal@kernel.org>
Move the check for the return value of the call to
xfs_select_open_zone_mru() inside the if that controls the call to this
function, so that we do not uselessly test again the value of oz when
pack_tight is false.
While at it, also fix a comment typo.
No functional changes.
Signed-off-by: Damien Le Moal <dlemoal@kernel.org>
---
fs/xfs/xfs_zone_alloc.c | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/fs/xfs/xfs_zone_alloc.c b/fs/xfs/xfs_zone_alloc.c
index 7d712d5a5ce0..a05418ac6a95 100644
--- a/fs/xfs/xfs_zone_alloc.c
+++ b/fs/xfs/xfs_zone_alloc.c
@@ -675,10 +675,11 @@ xfs_select_zone_nowait(
if (oz)
goto out_unlock;
- if (pack_tight)
+ if (pack_tight) {
oz = xfs_select_open_zone_mru(zi, write_hint);
- if (oz)
- goto out_unlock;
+ if (oz)
+ goto out_unlock;
+ }
/*
* See if we can open a new zone and use that so that data for different
@@ -689,7 +690,7 @@ xfs_select_zone_nowait(
goto out_unlock;
/*
- * Try to find an zone that is an ok match to colocate data with.
+ * Try to find a zone that is an ok match to colocate data with.
*/
oz = xfs_select_open_zone_lru(zi, write_hint, XFS_ZONE_ALLOC_OK);
if (oz)
--
2.53.0
next prev parent reply other threads:[~2026-03-15 0:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-14 23:55 [PATCH 0/3] Zoned XFS code improvements Damien Le Moal
2026-03-14 23:55 ` Damien Le Moal [this message]
2026-03-16 9:01 ` [PATCH 1/3] xfs: improve xfs_select_zone_nowait() Christoph Hellwig
2026-03-14 23:55 ` [PATCH 2/3] xfs: improve xfs_zoned_show_stats() Damien Le Moal
2026-03-16 9:02 ` Christoph Hellwig
2026-03-14 23:55 ` [PATCH 3/3] xfs: improve xfs_zoned_need_gc() Damien Le Moal
2026-03-16 9:03 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260314235508.183984-2-dlemoal@kernel.org \
--to=dlemoal@kernel.org \
--cc=cem@kernel.org \
--cc=hans.holmberg@wdc.com \
--cc=hch@lst.de \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox