From: "Darrick J. Wong" <djwong@kernel.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: aalbersh@kernel.org, linux-xfs@vger.kernel.org
Subject: Re: [PATCH 22/22] xfs_scrub: allow overrides of the media verification IO limits
Date: Fri, 20 Mar 2026 08:44:53 -0700 [thread overview]
Message-ID: <20260320154453.GC6223@frogsfrogsfrogs> (raw)
In-Reply-To: <abz0jpxjiVBe0hEQ@infradead.org>
On Fri, Mar 20, 2026 at 12:17:34AM -0700, Christoph Hellwig wrote:
> On Wed, Mar 18, 2026 at 09:51:16PM -0700, Darrick J. Wong wrote:
> > From: Darrick J. Wong <djwong@kernel.org>
> >
> > Allow power users to override the media verification IO size limits via
> > magic environment variables. For the background service, this can be
> > done via:
> >
> > [Service]
> > Environment=XFS_SCRUB_VERIFY_MAX_SIZE=128M
>
> So you'll need to hack the systemd unit files? How could we set this
> on a per-file system basis?
>
> Not really arguing against this, but we might end up needing more
> flexbility in the end.
I'd do per-fs tweaks by defining an xfs_property and telling users to
set it, e.g.
# xfs_property /home set scrub_verify_max_size=128M
I don't think we need to define the property right now, that can wait
until someone has time to do a more in depth analysis of what settings
adjustments are needed for modern hardware. I'm keener on figuring out
something that'd work more automagically because sysadmins are lazy. :)
--D
next prev parent reply other threads:[~2026-03-20 15:44 UTC|newest]
Thread overview: 71+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-19 4:37 [PATCHBOMB v10] xfsprogs: autonomous self healing of filesystems Darrick J. Wong
2026-03-19 4:38 ` [PATCHSET v10 1/2] " Darrick J. Wong
2026-03-19 4:39 ` [PATCH 01/26] libfrog: add a function to grab the path from an open fd and a file handle Darrick J. Wong
2026-03-19 4:39 ` [PATCH 02/26] libfrog: create healthmon event log library functions Darrick J. Wong
2026-03-19 4:39 ` [PATCH 03/26] libfrog: add support code for starting systemd services programmatically Darrick J. Wong
2026-03-19 4:39 ` [PATCH 04/26] libfrog: hoist a couple of service helper functions Darrick J. Wong
2026-03-19 4:40 ` [PATCH 05/26] libfrog: add wrappers for listmount and statmount Darrick J. Wong
2026-03-19 4:40 ` [PATCH 06/26] man2: document the healthmon ioctl Darrick J. Wong
2026-03-19 4:40 ` [PATCH 07/26] man2: document the media verification ioctl Darrick J. Wong
2026-03-19 4:40 ` [PATCH 08/26] xfs_io: monitor filesystem health events Darrick J. Wong
2026-03-19 4:41 ` [PATCH 09/26] xfs_io: add a media verify command Darrick J. Wong
2026-03-19 4:41 ` [PATCH 10/26] xfs_healer: create daemon to listen for health events Darrick J. Wong
2026-03-19 4:41 ` [PATCH 11/26] xfs_healer: enable repairing filesystems Darrick J. Wong
2026-03-19 4:41 ` [PATCH 12/26] xfs_healer: use getparents to look up file names Darrick J. Wong
2026-03-19 4:42 ` [PATCH 13/26] xfs_healer: create a per-mount background monitoring service Darrick J. Wong
2026-03-19 4:42 ` [PATCH 14/26] xfs_healer: create a service to start the per-mount healer service Darrick J. Wong
2026-03-19 4:42 ` [PATCH 15/26] xfs_healer: don't start service if kernel support unavailable Darrick J. Wong
2026-03-19 4:42 ` [PATCH 16/26] xfs_healer: use the autofsck fsproperty to select mode Darrick J. Wong
2026-03-19 4:43 ` [PATCH 17/26] xfs_healer: run full scrub after lost corruption events or targeted repair failure Darrick J. Wong
2026-03-19 4:43 ` [PATCH 18/26] xfs_healer: use getmntent to find moved filesystems Darrick J. Wong
2026-03-19 4:43 ` [PATCH 19/26] xfs_healer: use statmount to find moved filesystems even faster Darrick J. Wong
2026-03-20 7:11 ` Christoph Hellwig
2026-03-19 4:43 ` [PATCH 20/26] xfs_healer: validate that repair fds point to the monitored fs Darrick J. Wong
2026-03-19 4:44 ` [PATCH 21/26] xfs_healer: add a manual page Darrick J. Wong
2026-03-19 4:44 ` [PATCH 22/26] xfs_scrub: print systemd service names Darrick J. Wong
2026-03-19 4:44 ` [PATCH 23/26] xfs_io: add listmount and statmount commands Darrick J. Wong
2026-03-19 4:45 ` [PATCH 24/26] mkfs: enable online repair if all backrefs are enabled Darrick J. Wong
2026-03-19 4:45 ` [PATCH 25/26] debian/control: listify the build dependencies Darrick J. Wong
2026-03-19 4:45 ` [PATCH 26/26] debian: enable xfs_healer on the root filesystem by default Darrick J. Wong
2026-03-19 4:38 ` [PATCHSET v10 2/2] xfs_scrub: refactor to XFS_IOC_VERIFY_MEDIA Darrick J. Wong
2026-03-19 4:45 ` [PATCH 01/22] libfrog: allow bitmap_free to handle a null bitmap pointer Darrick J. Wong
2026-03-20 7:12 ` Christoph Hellwig
2026-03-19 4:46 ` [PATCH 02/22] mkfs: rename byte unit conversion macros Darrick J. Wong
2026-03-20 7:12 ` Christoph Hellwig
2026-03-19 4:46 ` [PATCH 03/22] libfrog: lift *BYTES helpers to convert.h Darrick J. Wong
2026-03-20 7:12 ` Christoph Hellwig
2026-03-19 4:46 ` [PATCH 04/22] xfs_scrub: report truncated devices as media errors Darrick J. Wong
2026-03-20 7:13 ` Christoph Hellwig
2026-03-19 4:46 ` [PATCH 05/22] xfs_scrub: fix i18n of the decode_special_owner return value Darrick J. Wong
2026-03-20 7:13 ` Christoph Hellwig
2026-03-19 4:47 ` [PATCH 06/22] scrub: remove the unused io_disk field in struct read_verify Darrick J. Wong
2026-03-19 4:47 ` [PATCH 07/22] xfs_scrub: move read verification scheduling to phase6.c Darrick J. Wong
2026-03-20 7:14 ` Christoph Hellwig
2026-03-19 4:47 ` [PATCH 08/22] scrub: simplify the read_verify_pool_alloc interface Darrick J. Wong
2026-03-19 4:47 ` [PATCH 09/22] xfs_scrub: don't pass the io_end_arg around everywhere Darrick J. Wong
2026-03-20 7:14 ` Christoph Hellwig
2026-03-19 4:48 ` [PATCH 10/22] scrub: use enum xfs_device for read verification Darrick J. Wong
2026-03-19 4:48 ` [PATCH 11/22] xfs_scrub: rename nr_io_threads Darrick J. Wong
2026-03-20 7:14 ` Christoph Hellwig
2026-03-19 4:48 ` [PATCH 12/22] scrub: simplify verifier threads calculation Darrick J. Wong
2026-03-19 4:48 ` [PATCH 13/22] xfs_scrub: move disk media verification error injection Darrick J. Wong
2026-03-19 4:49 ` [PATCH 14/22] xfs_scrub: use the verify media ioctl during phase 6 if possible Darrick J. Wong
2026-03-19 4:49 ` [PATCH 15/22] scrub: don't allocate disk for ioctl-based media verify Darrick J. Wong
2026-03-19 4:49 ` [PATCH 16/22] xfs_scrub: perform media scanning of the log region Darrick J. Wong
2026-03-20 7:15 ` Christoph Hellwig
2026-03-19 4:49 ` [PATCH 17/22] xfs_scrub: index read-verify pools by xfs_device ids Darrick J. Wong
2026-03-20 7:15 ` Christoph Hellwig
2026-03-19 4:50 ` [PATCH 18/22] xfs_scrub: move failmap and other outputs into read_verify_pool Darrick J. Wong
2026-03-20 7:15 ` Christoph Hellwig
2026-03-19 4:50 ` [PATCH 19/22] xfs_scrub: clean up device-related error messages Darrick J. Wong
2026-03-20 7:15 ` Christoph Hellwig
2026-03-19 4:50 ` [PATCH 20/22] xfs_scrub: drop SCSI_VERIFY code from disk Darrick J. Wong
2026-03-20 7:16 ` Christoph Hellwig
2026-03-19 4:51 ` [PATCH 21/22] xfs_scrub: raise media verification IO limits Darrick J. Wong
2026-03-20 7:16 ` Christoph Hellwig
2026-03-20 15:46 ` Darrick J. Wong
2026-03-19 4:51 ` [PATCH 22/22] xfs_scrub: allow overrides of the " Darrick J. Wong
2026-03-20 7:17 ` Christoph Hellwig
2026-03-20 15:44 ` Darrick J. Wong [this message]
2026-03-23 6:08 ` Christoph Hellwig
2026-03-23 15:18 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260320154453.GC6223@frogsfrogsfrogs \
--to=djwong@kernel.org \
--cc=aalbersh@kernel.org \
--cc=hch@infradead.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox