From: Christoph Hellwig <hch@lst.de>
To: Hans Holmberg <hans.holmberg@wdc.com>
Cc: Carlos Maiolino <cem@kernel.org>,
Dave Chinner <david@fromorbit.com>,
"Darrick J . Wong" <djwong@kernel.org>,
Christoph Hellwig <hch@lst.de>,
Damien Le Moal <dlemoal@kernel.org>,
linux-xfs@vger.kernel.org
Subject: Re: [PATCH] xfs: start gc on zonegc_low_space attribute updates
Date: Mon, 23 Mar 2026 07:36:41 +0100 [thread overview]
Message-ID: <20260323063641.GA24722@lst.de> (raw)
In-Reply-To: <20260320130256.35225-1-hans.holmberg@wdc.com>
> + mp->m_zonegc_low_space = val;
> + if (!xfs_is_readonly(mp))
> + xfs_zone_gc_start(mp);
Do we need to take s_umount here to prevent races with remount?
(Not that it has any major effect, but we might as well get it
tight).
Otherwise looks good. Do we want a test to ensure this takes
effect? And one that it doesn't do anything stupid on a hard
read-only file system?
next prev parent reply other threads:[~2026-03-23 6:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-20 13:02 [PATCH] xfs: start gc on zonegc_low_space attribute updates Hans Holmberg
2026-03-20 14:39 ` Darrick J. Wong
2026-03-23 10:01 ` Hans Holmberg
2026-03-20 23:28 ` Damien Le Moal
2026-03-23 6:36 ` Christoph Hellwig [this message]
2026-03-23 10:32 ` Hans Holmberg
2026-03-25 6:04 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260323063641.GA24722@lst.de \
--to=hch@lst.de \
--cc=cem@kernel.org \
--cc=david@fromorbit.com \
--cc=djwong@kernel.org \
--cc=dlemoal@kernel.org \
--cc=hans.holmberg@wdc.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox