From: Christoph Hellwig <hch@lst.de>
To: Hans Holmberg <Hans.Holmberg@wdc.com>
Cc: Christoph Hellwig <hch@lst.de>,
"zlang@kernel.org" <zlang@kernel.org>,
"fstests@vger.kernel.org" <fstests@vger.kernel.org>,
Damien Le Moal <dlemoal@kernel.org>,
"Darrick J . Wong" <djwong@kernel.org>,
"linux-xfs@vger.kernel.org" <linux-xfs@vger.kernel.org>
Subject: Re: [PATCH] xfs: test that zone_gc_low_space writes start gc for rw fses
Date: Thu, 26 Mar 2026 15:12:26 +0100 [thread overview]
Message-ID: <20260326141226.GA15900@lst.de> (raw)
In-Reply-To: <0a3d3ee7-2545-4f18-9c04-0d7a3348110c@wdc.com>
On Thu, Mar 26, 2026 at 01:41:46PM +0000, Hans Holmberg wrote:
> That would be useful I think.
> And make them not specific to scratch?
>
> _xfs_get_mountstats <MOUNTPOINT>
> _xfs_get_rt_gc_required <MOUNTPOINT>
> _xfs_get_user_available_rt_blocks <MOUNTPOINT>
Sounds good!
>
> >
> >> +
> >> +# figure out if the rt section is internal or not
> >> +if [ -z "$SCRATCH_RTDEV" ]; then
> >> + zdev=$SCRATCH_DEV
> >> +else
> >> + zdev=$SCRATCH_RTDEV
> >> +fi
> >
> > Same for this asa new helper?
>
> Yes, something like:
>
> _xfs_get_scratch_rtdev
Maybe _xfs_get_scratch_rtdev_bdev? That might sounds a bit redundant,
but I think that's good to make the usage of this clear. A comment
explaining it would also be useful here.
prev parent reply other threads:[~2026-03-26 14:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-25 12:50 [PATCH] xfs: test that zone_gc_low_space writes start gc for rw fses Hans Holmberg
2026-03-26 6:11 ` Christoph Hellwig
2026-03-26 13:41 ` Hans Holmberg
2026-03-26 14:12 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260326141226.GA15900@lst.de \
--to=hch@lst.de \
--cc=Hans.Holmberg@wdc.com \
--cc=djwong@kernel.org \
--cc=dlemoal@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=zlang@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox