From: Christoph Hellwig <hch@lst.de>
To: Carlos Maiolino <cem@kernel.org>
Cc: linux-xfs@vger.kernel.org
Subject: [PATCH 1/2] xfs: remove a duplicate assert in xfs_setattr_size
Date: Mon, 30 Mar 2026 15:15:59 +0200 [thread overview]
Message-ID: <20260330131607.3904269-2-hch@lst.de> (raw)
In-Reply-To: <20260330131607.3904269-1-hch@lst.de>
There already is an assert that checks for uid and gid changes besides a
lot of others at the beginning of the function.
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
fs/xfs/xfs_iops.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/fs/xfs/xfs_iops.c b/fs/xfs/xfs_iops.c
index 208543e57eda..b0256a4a8aa8 100644
--- a/fs/xfs/xfs_iops.c
+++ b/fs/xfs/xfs_iops.c
@@ -1109,7 +1109,6 @@ xfs_setattr_size(
xfs_inode_clear_eofblocks_tag(ip);
}
- ASSERT(!(iattr->ia_valid & (ATTR_UID | ATTR_GID)));
setattr_copy(idmap, inode, iattr);
xfs_trans_log_inode(tp, ip, XFS_ILOG_CORE);
--
2.47.3
next prev parent reply other threads:[~2026-03-30 13:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-30 13:15 small cleanups for ->setattr Christoph Hellwig
2026-03-30 13:15 ` Christoph Hellwig [this message]
2026-04-07 11:01 ` [PATCH 1/2] xfs: remove a duplicate assert in xfs_setattr_size Carlos Maiolino
2026-04-07 13:38 ` Carlos Maiolino
2026-03-30 13:16 ` [PATCH 2/2] xfs: fold xfs_setattr_size into xfs_vn_setattr_size Christoph Hellwig
2026-04-07 11:02 ` Carlos Maiolino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260330131607.3904269-2-hch@lst.de \
--to=hch@lst.de \
--cc=cem@kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox