Re: [PATCH v3 1/2] fsr: package function should check for negative errors

["Darrick J. Wong" <djwong@kernel.org>]

On Tue, Mar 31, 2026 at 02:26:30PM +0200, cem@kernel.org wrote:
> From: Carlos Maiolino <cem@kernel.org>
> 
> xfrog_defragrange as most other functions from libfrog return
> a negative error value, while xfs_fsr's packfile(), expects
> a positive error value.
> 
> Whenever xfrog_defragrange fails, the switch case always falls into the
> default clausule, making the error message pointless.
> Fix this by inverting xfrog_defragrange() return value call.
> 
> Signed-off-by: Carlos Maiolino <cmaiolino@redhat.com>
> 
> ---
> V3:
> 	Just change xfrog_defragrange() return signal.

Looks good to me, thanks for fixing this :)
Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>

--D

> 
> V2:
> 	Change packfile() to check for negative error values
> 	instead of changing the return sign from xfrog_defragrange().
> 
>  fsr/xfs_fsr.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fsr/xfs_fsr.c b/fsr/xfs_fsr.c
> index 8845ff172fcb..390f7c5276df 100644
> --- a/fsr/xfs_fsr.c
> +++ b/fsr/xfs_fsr.c
> @@ -1459,7 +1459,7 @@ packfile(
>          }
>  
>  	/* Swap the extents */
> -	error = xfrog_defragrange(file_fd->fd, &xdf);
> +	error = -xfrog_defragrange(file_fd->fd, &xdf);
>  	switch (error) {
>  		case 0:
>  			break;
> -- 
> 2.53.0
> 
>