Re: [PATCH v6 04/22] fsverity: pass digest size and hash of the empty block to ->write

Eric Biggers
2026-04-01T23:36:33Z

On Tue, Mar 31, 2026 at 11:28:05PM +0200, Andrey Albershteyn wrote:
> Let filesystem iterate over hashes in the block and check if these are
> hashes of zeroed data blocks. XFS will use this to decide if it want to
> store tree block full of these hashes.
>
> Signed-off-by: Andrey Albershteyn <aalbersh@kernel.org>
> Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>

Acked-by: Eric Biggers <ebiggers@kernel.org>

> pass digest size and hash of the empty block to ->write

"empty block" => "all-zeroes block"

(it's not empty, it's all-zeroes)

> + * @zero_digest: the hash of a merkle block-sized buffer of zeroes

"a merkle block-sized buffer of zeroes" => "the all-zeroes block"

(to hopefully make it clear, as in patch 3, that it's the salted block
hash, not the value that fsverity_hash_buffer() gives)

> + * @zero_digest: the hash of a merkle block-sized buffer of zeroes

Likewise.

- Eric