From: Christoph Hellwig <hch@lst.de>
To: Zorro Lang <zlang@redhat.com>
Cc: Christoph Hellwig <hch@lst.de>,
zlang@kernel.org, djwong@kernel.org, dlemoal@kernel.org,
hans.holmberg@wdc.com, fstests@vger.kernel.org,
linux-xfs@vger.kernel.org
Subject: Re: [PATCH v2] xfs: add a test for number of open zones on conventional devices
Date: Wed, 1 Apr 2026 08:18:28 +0200 [thread overview]
Message-ID: <20260401061828.GA24293@lst.de> (raw)
In-Reply-To: <20260331211807.gofhlabxlr3mdxnr@doltdoltdolt>
On Wed, Apr 01, 2026 at 05:18:07AM +0800, Zorro Lang wrote:
> > +
> > +_scratch_mkfs -b size=${bsize} -r zoned=1,rgsize=${blocks}b \
> > + > "$seqres.full" 2>&1
>
> I usually tack on "|| _fail 'mkfs failed'" after _scratch_mount if it's
> using extra options. That way, we'll know for sure if the mkfs actually
> failed.
Yes, that is useful here, especially if we want to support older kernels
before the zoned device support or !CONFIG_XFS_RT kernels.
> > +_has_fs_sysfs_attr $SCRATCH_DEV zoned/nr_open_zones || \
> > + _notrun "This test requires /sys/fs/${FSTYP}/$SCRATCH_DEV/zoned/nr_open_zones"
>
> Can this be replaced with "_require_fs_sysfs_attr" ? _require_fs_sysfs_attr also can
> help to get the real path to the sysfs directory for the fs on a device.
No, this must happen on the scratch file system where we force the
zoned allocator, as the attribute only exists for those.
next prev parent reply other threads:[~2026-04-01 6:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-31 15:23 [PATCH v2] xfs: add a test for number of open zones on conventional devices Christoph Hellwig
2026-03-31 19:40 ` Damien Le Moal
2026-03-31 21:18 ` Zorro Lang
2026-04-01 6:18 ` Christoph Hellwig [this message]
2026-04-01 7:59 ` Zorro Lang
2026-04-01 14:06 ` Christoph Hellwig
2026-04-06 17:05 ` Zorro Lang
2026-04-07 6:27 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260401061828.GA24293@lst.de \
--to=hch@lst.de \
--cc=djwong@kernel.org \
--cc=dlemoal@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=hans.holmberg@wdc.com \
--cc=linux-xfs@vger.kernel.org \
--cc=zlang@kernel.org \
--cc=zlang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox