From: Christoph Hellwig <hch@lst.de>
To: Hans Holmberg <Hans.Holmberg@wdc.com>
Cc: Christoph Hellwig <hch@lst.de>, "cem@kernel.org" <cem@kernel.org>,
"dlemoal@kernel.org" <dlemoal@kernel.org>,
"linux-xfs@vger.kernel.org" <linux-xfs@vger.kernel.org>
Subject: Re: [PATCH] xfs: fix number of GC bvecs
Date: Mon, 6 Apr 2026 07:51:42 +0200 [thread overview]
Message-ID: <20260406055142.GD16443@lst.de> (raw)
In-Reply-To: <c052461d-31d4-4296-8268-8fe3c7863bc3@wdc.com>
On Thu, Apr 02, 2026 at 07:25:44AM +0000, Hans Holmberg wrote:
> On 01/04/2026 15:58, Christoph Hellwig wrote:
> > GC scratch allocations can wrap around and use the same buffer twice, and
> > the current code fails to account for that. So far this worked due to
> > rounding in the block layer, but changes to the bio allocator drop the
> > over-provisioning and generic/256 or generic/361 will not usually fail
> > when running against the current block tree.
>
> I have a hard time understanding the "will not usually fail" part,
> but apart from that, the patch looks good:
The not should be a now.
next prev parent reply other threads:[~2026-04-06 5:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-01 13:58 [PATCH] xfs: fix number of GC bvecs Christoph Hellwig
2026-04-01 19:47 ` Damien Le Moal
2026-04-02 7:25 ` Hans Holmberg
2026-04-06 5:51 ` Christoph Hellwig [this message]
2026-04-02 18:49 ` Niklas Cassel
2026-04-06 5:52 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260406055142.GD16443@lst.de \
--to=hch@lst.de \
--cc=Hans.Holmberg@wdc.com \
--cc=cem@kernel.org \
--cc=dlemoal@kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox