From: "Darrick J. Wong" <djwong@kernel.org>
To: alexjlzheng@gmail.com
Cc: cem@kernel.org, kees@kernel.org, alexjlzheng@tencent.com,
linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] xfs: remove the meaningless XFS_ALLOC_FLAG_FREEING
Date: Fri, 10 Apr 2026 09:42:35 -0700 [thread overview]
Message-ID: <20260410164235.GT6254@frogsfrogsfrogs> (raw)
In-Reply-To: <20260410101106.2523665-1-alexjlzheng@tencent.com>
On Fri, Apr 10, 2026 at 06:11:06PM +0800, alexjlzheng@gmail.com wrote:
> From: Jinliang Zheng <alexjlzheng@tencent.com>
>
> In xfs_refcount_finish_one(), there's no need to pass
> XFS_ALLOC_FLAG_FREEING to xfs_alloc_read_agf().
>
> So remove it.
>
> Signed-off-by: Jinliang Zheng <alexjlzheng@tencent.com>
Looks ok,
Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>
--D
> ---
> fs/xfs/libxfs/xfs_refcount.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/fs/xfs/libxfs/xfs_refcount.c b/fs/xfs/libxfs/xfs_refcount.c
> index 40c7f0ff6cf3..0ec6ccd8b4dc 100644
> --- a/fs/xfs/libxfs/xfs_refcount.c
> +++ b/fs/xfs/libxfs/xfs_refcount.c
> @@ -1414,8 +1414,7 @@ xfs_refcount_finish_one(
> if (rcur == NULL) {
> struct xfs_perag *pag = to_perag(ri->ri_group);
>
> - error = xfs_alloc_read_agf(pag, tp,
> - XFS_ALLOC_FLAG_FREEING, &agbp);
> + error = xfs_alloc_read_agf(pag, tp, 0, &agbp);
> if (error)
> return error;
>
> --
> 2.49.0
>
prev parent reply other threads:[~2026-04-10 16:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-10 10:11 [PATCH] xfs: remove the meaningless XFS_ALLOC_FLAG_FREEING alexjlzheng
2026-04-10 16:42 ` Darrick J. Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260410164235.GT6254@frogsfrogsfrogs \
--to=djwong@kernel.org \
--cc=alexjlzheng@gmail.com \
--cc=alexjlzheng@tencent.com \
--cc=cem@kernel.org \
--cc=kees@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox