* [PATCH] xfs: remove the meaningless XFS_ALLOC_FLAG_FREEING
@ 2026-04-10 10:11 alexjlzheng
2026-04-10 16:42 ` Darrick J. Wong
0 siblings, 1 reply; 2+ messages in thread
From: alexjlzheng @ 2026-04-10 10:11 UTC (permalink / raw)
To: cem, djwong, kees; +Cc: alexjlzheng, linux-xfs, linux-kernel
From: Jinliang Zheng <alexjlzheng@tencent.com>
In xfs_refcount_finish_one(), there's no need to pass
XFS_ALLOC_FLAG_FREEING to xfs_alloc_read_agf().
So remove it.
Signed-off-by: Jinliang Zheng <alexjlzheng@tencent.com>
---
fs/xfs/libxfs/xfs_refcount.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/fs/xfs/libxfs/xfs_refcount.c b/fs/xfs/libxfs/xfs_refcount.c
index 40c7f0ff6cf3..0ec6ccd8b4dc 100644
--- a/fs/xfs/libxfs/xfs_refcount.c
+++ b/fs/xfs/libxfs/xfs_refcount.c
@@ -1414,8 +1414,7 @@ xfs_refcount_finish_one(
if (rcur == NULL) {
struct xfs_perag *pag = to_perag(ri->ri_group);
- error = xfs_alloc_read_agf(pag, tp,
- XFS_ALLOC_FLAG_FREEING, &agbp);
+ error = xfs_alloc_read_agf(pag, tp, 0, &agbp);
if (error)
return error;
--
2.49.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] xfs: remove the meaningless XFS_ALLOC_FLAG_FREEING
2026-04-10 10:11 [PATCH] xfs: remove the meaningless XFS_ALLOC_FLAG_FREEING alexjlzheng
@ 2026-04-10 16:42 ` Darrick J. Wong
0 siblings, 0 replies; 2+ messages in thread
From: Darrick J. Wong @ 2026-04-10 16:42 UTC (permalink / raw)
To: alexjlzheng; +Cc: cem, kees, alexjlzheng, linux-xfs, linux-kernel
On Fri, Apr 10, 2026 at 06:11:06PM +0800, alexjlzheng@gmail.com wrote:
> From: Jinliang Zheng <alexjlzheng@tencent.com>
>
> In xfs_refcount_finish_one(), there's no need to pass
> XFS_ALLOC_FLAG_FREEING to xfs_alloc_read_agf().
>
> So remove it.
>
> Signed-off-by: Jinliang Zheng <alexjlzheng@tencent.com>
Looks ok,
Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>
--D
> ---
> fs/xfs/libxfs/xfs_refcount.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/fs/xfs/libxfs/xfs_refcount.c b/fs/xfs/libxfs/xfs_refcount.c
> index 40c7f0ff6cf3..0ec6ccd8b4dc 100644
> --- a/fs/xfs/libxfs/xfs_refcount.c
> +++ b/fs/xfs/libxfs/xfs_refcount.c
> @@ -1414,8 +1414,7 @@ xfs_refcount_finish_one(
> if (rcur == NULL) {
> struct xfs_perag *pag = to_perag(ri->ri_group);
>
> - error = xfs_alloc_read_agf(pag, tp,
> - XFS_ALLOC_FLAG_FREEING, &agbp);
> + error = xfs_alloc_read_agf(pag, tp, 0, &agbp);
> if (error)
> return error;
>
> --
> 2.49.0
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-04-10 16:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-04-10 10:11 [PATCH] xfs: remove the meaningless XFS_ALLOC_FLAG_FREEING alexjlzheng
2026-04-10 16:42 ` Darrick J. Wong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox