Linux XFS filesystem development
 help / color / mirror / Atom feed
From: "Darrick J. Wong" <djwong@kernel.org>
To: Anthony Iliopoulos <ailiop@suse.com>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH 1/4] configure: always check for statmount supported_mask
Date: Wed, 13 May 2026 17:27:44 -0700	[thread overview]
Message-ID: <20260514002744.GR9555@frogsfrogsfrogs> (raw)
In-Reply-To: <20260513193040.2130-2-ailiop@suse.com>

On Wed, May 13, 2026 at 09:30:37PM +0200, Anthony Iliopoulos wrote:
> On systems with kernel headers older than v6.8 that preceed the addition
> of the statmount syscall, have_listmount will be set to false and thus
> checking of the statmount supported_mask is being skipped since the
> check is currently conditional to listmount support.

ahah, that's why it doesn't build on Mageia 9, I gather.

> This causes compilation failures since need_internal_statmount will not
> be set, and thus struct statmount will not be available to xfs_healer.
> 
> Fix this by always checking for statmount supported_mask support even
> when listmount is not available.
> 
> Signed-off-by: Anthony Iliopoulos <ailiop@suse.com>
> ---
>  configure.ac | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/configure.ac b/configure.ac
> index 2ac5e3d8181a..fe2ffddd9ec4 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -192,8 +192,8 @@ AC_HAVE_CLOSE_RANGE
>  AC_HAVE_LISTMOUNT
>  if test "$have_listmount" = "yes"; then
>  	AC_HAVE_LISTMOUNT_NS_FD
> -	AC_HAVE_STATMOUNT_SUPPORTED_MASK
>  fi
> +AC_HAVE_STATMOUNT_SUPPORTED_MASK

Yeah, we should test both.  Sorry about the braino there. :/
Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>

--D

>  AC_HAVE_FANOTIFY_MOUNTINFO
>  
>  if test "$enable_ubsan" = "yes" || test "$enable_ubsan" = "probe"; then
> -- 
> 2.49.0
> 
> 

  reply	other threads:[~2026-05-14  0:27 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-13 19:30 [PATCH 0/4] xfsprogs: fix xfs_healer build issues on older kernels Anthony Iliopoulos
2026-05-13 19:30 ` [PATCH 1/4] configure: always check for statmount supported_mask Anthony Iliopoulos
2026-05-14  0:27   ` Darrick J. Wong [this message]
2026-05-13 19:30 ` [PATCH 2/4] libfrog: add missing statmount flag definitions Anthony Iliopoulos
2026-05-14  0:27   ` Darrick J. Wong
2026-05-13 19:30 ` [PATCH 3/4] libfrog: add fallback stubs for libfrog_statmount and fstatmount Anthony Iliopoulos
2026-05-14  0:29   ` Darrick J. Wong
2026-05-13 19:30 ` [PATCH 4/4] gitignore: add xfs_healer binaries and services Anthony Iliopoulos
2026-05-14  0:28   ` Darrick J. Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260514002744.GR9555@frogsfrogsfrogs \
    --to=djwong@kernel.org \
    --cc=ailiop@suse.com \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox