From: "Darrick J. Wong" <djwong@kernel.org>
To: Lukas Herbolt <lukas@herbolt.com>
Cc: zlang@kernel.org, fstests@vger.kernel.org,
xfs <linux-xfs@vger.kernel.org>
Subject: Re: [PATCH v2 2/4] common/xfs: helper function to check if -l/-d/-r concurrecy flags.
Date: Thu, 14 May 2026 07:46:09 -0700 [thread overview]
Message-ID: <20260514144609.GY9544@frogsfrogsfrogs> (raw)
In-Reply-To: <20260514113910.866888-6-lukas@herbolt.com>
On Thu, May 14, 2026 at 01:39:11PM +0200, Lukas Herbolt wrote:
> Check if the requested flag is supported by the mkfs.xfs on scratch
> device.
>
> Signed-off-by: Lukas Herbolt <lukas@herbolt.com>
> ---
> ---
> changes v2:
> -l/-d were introduced at same release no need to check both
Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>
--D
> common/xfs | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/common/xfs b/common/xfs
> index f7a6d2f2f03a..c48b043faf80 100644
> --- a/common/xfs
> +++ b/common/xfs
> @@ -2399,3 +2399,12 @@ _require_xfs_healer()
> _xfs_healer --supported "$@" &>/dev/null || \
> _notrun "health monitoring not supported on this kernel"
> }
> +
> +# -l/-d concurrency came in same xfsprogs release v6.7
> + _scratch_mkfs_xfs_supports_concurrency()
> +{
> + local arg="${1:-d}"
> +
> + test "$arg" = "-l" && arg="-d"
> + _scratch_mkfs_xfs_supported "$arg" concurrency=0
> +}
> --
> 2.54.0
>
>
next prev parent reply other threads:[~2026-05-14 14:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20260514113910.866888-2-lukas@herbolt.com>
[not found] ` <20260514113910.866888-4-lukas@herbolt.com>
2026-05-14 14:45 ` [PATCH v2 1/4] common/rc: Add helper to calculate percentage of free space available Darrick J. Wong
[not found] ` <20260514113910.866888-6-lukas@herbolt.com>
2026-05-14 14:46 ` Darrick J. Wong [this message]
[not found] ` <20260514113910.866888-8-lukas@herbolt.com>
2026-05-14 14:46 ` [PATCH v2 3/4] generic/{102,172,347}: Adapt test for XFS on systems with 128+CPUs + SSDs Darrick J. Wong
[not found] ` <20260514113910.866888-10-lukas@herbolt.com>
2026-05-14 14:47 ` [PATCH v2 4/4] xfs/21{6,7} Use default -l concurrency=0 on mkfs.xfs that supports it Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260514144609.GY9544@frogsfrogsfrogs \
--to=djwong@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=lukas@herbolt.com \
--cc=zlang@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox