Linux XFS filesystem development
 help / color / mirror / Atom feed
From: "Darrick J. Wong" <djwong@kernel.org>
To: Lukas Herbolt <lukas@herbolt.com>
Cc: sandeen@sandeen.net, aalbersh@kernel.org,
	linux-xfs@vger.kernel.org, Theodore Ts'o <tytso@mit.edu>
Subject: Re: [RFC PATCH 0/1] Add default config file for mkfs.xfs
Date: Thu, 14 May 2026 08:05:30 -0700	[thread overview]
Message-ID: <20260514150530.GV9555@frogsfrogsfrogs> (raw)
In-Reply-To: <20260514143716.893814-2-lukas@herbolt.com>

[add ted to cc]

On Thu, May 14, 2026 at 04:37:16PM +0200, Lukas Herbolt wrote:
> Hi all,
> The default values cannot always satisfy everybody and users/packagers
> should be able to override defaults without the need of specifying
> configuration file on command line. It was previously discussed in
> here [1]. 

Hmm.  A long time ago Ted asked for a slghtly different alteration to
help him make running fstests easier.  What he wanted iirc was a way to
install a set of default mkfs settings from a config file, but still
allow the settings to be overridden by cli arguments.

Apparently I never sent the patch because it doesn't exist in lore, so I
suppose I should send it now. ;)

> The proposed patch adds /etc/mkfs.xfs.conf where the default values
> can be set.  It also lightly changes the default behavior for -l/-d/-r
> concurrency allowing now to be set to -1 to keep autodetection on
> SSDs.

I don't think I like magic negative numbers, but I'll save that for my
reply to the actual patch.

--D

> https://lore.kernel.org/linux-xfs/84c8a5e5-938d-4745-996d-4237009c9cc5@sandeen.net/
> 
> Lukas Herbolt (1):
>   xfsprogs: mkfs.xfs add default configuration file.
> 
>  include/builddefs.in |  1 +
>  mkfs/Makefile        |  3 ++
>  mkfs/mkfs.xfs.conf   | 50 ++++++++++++++++++++++++++++++
>  mkfs/xfs_mkfs.c      | 72 +++++++++++++++++++++++++++++++++++++++-----
>  4 files changed, 119 insertions(+), 7 deletions(-)
>  create mode 100644 mkfs/mkfs.xfs.conf
> 
> -- 
> 2.54.0
> 
> 

      parent reply	other threads:[~2026-05-14 15:05 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-14 14:37 [RFC PATCH 0/1] Add default config file for mkfs.xfs Lukas Herbolt
2026-05-14 14:37 ` [RFC PATCH 1/1] xfsprogs: mkfs.xfs add default configuration file Lukas Herbolt
2026-05-14 15:21   ` Carlos Maiolino
2026-05-14 16:05     ` Eric Sandeen
2026-05-14 16:29       ` Darrick J. Wong
2026-05-14 16:27   ` Darrick J. Wong
2026-05-14 15:05 ` Darrick J. Wong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260514150530.GV9555@frogsfrogsfrogs \
    --to=djwong@kernel.org \
    --cc=aalbersh@kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    --cc=lukas@herbolt.com \
    --cc=sandeen@sandeen.net \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox