From: Christoph Hellwig <hch@lst.de>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>, Carlos Maiolino <cem@kernel.org>,
linux-xfs@vger.kernel.org
Subject: Re: [PATCH 5/9] xfs: add a xfs_rmap_inode_owner helper
Date: Thu, 28 May 2026 10:28:52 +0200 [thread overview]
Message-ID: <20260528082852.GA6893@lst.de> (raw)
In-Reply-To: <20260528052346.GJ6078@frogsfrogsfrogs>
On Wed, May 27, 2026 at 10:23:46PM -0700, Darrick J. Wong wrote:
> > My direct aim was to reduce uses of i_ino so I looked for common
> > patterns. I also generally prefer APIs that pass typesave objects
> > over those passing integers as handles wherever possible.
>
> I'm curious, then, why are most of these new helpers macros instead of
> type-checkable static inline functions?
For these rmap ones because of our header mess - xfs_rmap.h is included
without or before xfs_inode.h, so without giant reshuffling using inlines
here will fail the compile.
For the xfs_format.h ones mostly to follow the surrounding style,
although if I tried I'd probably run into the same header ordering mess.
next prev parent reply other threads:[~2026-05-28 8:28 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-15 13:50 remove struct xfs_inode.i_ino Christoph Hellwig
2026-05-15 13:50 ` [PATCH 1/9] xfs: add a XFS_INODE_TO_AGNO helper Christoph Hellwig
2026-05-18 9:21 ` Carlos Maiolino
2026-05-15 13:50 ` [PATCH 2/9] xfs: add a XFS_INODE_TO_AGINO helper Christoph Hellwig
2026-05-18 11:04 ` Carlos Maiolino
2026-05-15 13:50 ` [PATCH 3/9] xfs: add a XFS_INO_TO_FSB helper Christoph Hellwig
2026-05-18 11:06 ` Carlos Maiolino
2026-05-15 13:50 ` [PATCH 4/9] xfs: add a xfs_rmap_inode_bmbt_owner Christoph Hellwig
2026-05-18 11:14 ` Carlos Maiolino
2026-05-15 13:50 ` [PATCH 5/9] xfs: add a xfs_rmap_inode_owner helper Christoph Hellwig
2026-05-18 11:14 ` Carlos Maiolino
2026-05-18 13:16 ` Christoph Hellwig
2026-05-18 13:23 ` Carlos Maiolino
2026-05-18 13:28 ` Christoph Hellwig
2026-05-28 5:23 ` Darrick J. Wong
2026-05-28 8:28 ` Christoph Hellwig [this message]
2026-05-18 11:23 ` Carlos Maiolino
2026-05-15 13:50 ` [PATCH 6/9] xfs: add a xchk_ip_set_corrupt helper Christoph Hellwig
2026-05-18 11:22 ` Carlos Maiolino
2026-05-15 13:50 ` [PATCH 7/9] xfs: convert xchk_inode_xref_set_corrupt to xchk_ip_xref_set_corrupt Christoph Hellwig
2026-05-18 11:17 ` Carlos Maiolino
2026-05-15 13:50 ` [PATCH 8/9] xfs: remove xfs_setup_existing_inode Christoph Hellwig
2026-05-18 11:18 ` Carlos Maiolino
2026-05-15 13:50 ` [PATCH 9/9] xfs: remove the i_ino field in struct xfs_inode Christoph Hellwig
2026-05-18 11:43 ` Carlos Maiolino
2026-05-28 5:24 ` remove struct xfs_inode.i_ino Darrick J. Wong
2026-05-29 4:33 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260528082852.GA6893@lst.de \
--to=hch@lst.de \
--cc=cem@kernel.org \
--cc=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox