From: Christoph Hellwig <hch@lst.de>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>, Carlos Maiolino <cem@kernel.org>,
linux-xfs@vger.kernel.org
Subject: Re: [PATCH 3/5] xfs: massage xfs_imap_to_bp into xfs_read_icluster
Date: Tue, 2 Jun 2026 07:37:46 +0200 [thread overview]
Message-ID: <20260602053746.GC32429@lst.de> (raw)
In-Reply-To: <20260602044707.GP6078@frogsfrogsfrogs>
On Mon, Jun 01, 2026 at 09:47:07PM -0700, Darrick J. Wong wrote:
> > struct xfs_mount *mp,
> > struct xfs_trans *tp,
> > - struct xfs_imap *imap,
> > + xfs_daddr_t bno,
>
> Hmm. Most of the code I've looked at in xfs uses "bno" for
> xfs_{fs,ag,rt,rg}block_t variables.
>
> Though for xfs_daddr_t values it's less clear -- half seem to use bno,
> the rest just call it daddr. Maybe this function should s/bno/daddr/ ?
Sounds reasonable, but as you noticed this is replaced by an agbno a
little later anyway.
next prev parent reply other threads:[~2026-06-02 5:37 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-01 12:43 shrink struct xfs_imap Christoph Hellwig
2026-06-01 12:43 ` [PATCH 1/5] xfs: cleanup xfs_imap Christoph Hellwig
2026-06-02 4:50 ` Darrick J. Wong
2026-06-01 12:43 ` [PATCH 2/5] xfs: remove im_len field in struct xfs_imap Christoph Hellwig
2026-06-02 4:43 ` Darrick J. Wong
2026-06-01 12:43 ` [PATCH 3/5] xfs: massage xfs_imap_to_bp into xfs_read_icluster Christoph Hellwig
2026-06-02 4:47 ` Darrick J. Wong
2026-06-02 5:37 ` Christoph Hellwig [this message]
2026-06-01 12:43 ` [PATCH 4/5] xfs: store an agbno in struct xfs_imap Christoph Hellwig
2026-06-02 4:49 ` Darrick J. Wong
2026-06-01 12:43 ` [PATCH 5/5] xfs: mark struct xfs_imap as __packed Christoph Hellwig
2026-06-02 4:49 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260602053746.GC32429@lst.de \
--to=hch@lst.de \
--cc=cem@kernel.org \
--cc=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox