From: Christoph Hellwig <hch@lst.de>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: aalbersh@kernel.org, linux-xfs@vger.kernel.org, hch@lst.de
Subject: Re: [PATCH 7/7] xfs_healer: coordinate access to weakhandle::mntpoint correctly
Date: Tue, 2 Jun 2026 08:34:09 +0200 [thread overview]
Message-ID: <20260602063409.GG2185@lst.de> (raw)
In-Reply-To: <178037627172.588879.10288701801654311276.stgit@frogsfrogsfrogs>
On Mon, Jun 01, 2026 at 09:59:53PM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@kernel.org>
>
> Codex complained about a potential UAF in the weakhandle code if one
> thread is walking weakhandle::mntpoint at exactly the same instant that
The :: notion here looks kinda weird.
Otherwise looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
prev parent reply other threads:[~2026-06-02 6:34 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-02 4:58 [PATCHSET] xfs_healer: codex-inspired bug fixes for 7.1 Darrick J. Wong
2026-06-02 4:58 ` [PATCH 1/7] xfs_healer: fix error reporting Darrick J. Wong
2026-06-02 6:31 ` Christoph Hellwig
2026-06-02 4:58 ` [PATCH 2/7] xfs_healer: recommend offline fsck for XCORRUPT repairs Darrick J. Wong
2026-06-02 6:31 ` Christoph Hellwig
2026-06-02 4:58 ` [PATCH 3/7] xfs_healer: initialize variable here Darrick J. Wong
2026-06-02 6:32 ` Christoph Hellwig
2026-06-02 4:59 ` [PATCH 4/7] xfs_healer: run a full xfs_scrub repair if we don't know how to do a spot repair Darrick J. Wong
2026-06-02 6:32 ` Christoph Hellwig
2026-06-02 4:59 ` [PATCH 5/7] xfs_healer: fix Makefile errors Darrick J. Wong
2026-06-02 6:32 ` Christoph Hellwig
2026-06-02 4:59 ` [PATCH 6/7] xfs_healer: don't leak wh->mntpoint if fd_to_handle fails Darrick J. Wong
2026-06-02 6:33 ` Christoph Hellwig
2026-06-02 4:59 ` [PATCH 7/7] xfs_healer: coordinate access to weakhandle::mntpoint correctly Darrick J. Wong
2026-06-02 6:34 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260602063409.GG2185@lst.de \
--to=hch@lst.de \
--cc=aalbersh@kernel.org \
--cc=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox