Re: [PATCH v3 2/2] xfs: shut down the filesystem on a failed mount

[kernel test robot <lkp@intel.com>]

Hi Mikhail,

kernel test robot noticed the following build warnings:

[auto build test WARNING on xfs-linux/for-next]
[also build test WARNING on linus/master v7.1-rc6 next-20260605]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Mikhail-Lobanov/xfs-shut-down-the-filesystem-on-a-failed-mount/20260605-175001
base:   https://git.kernel.org/pub/scm/fs/xfs/xfs-linux.git for-next
patch link:    https://lore.kernel.org/r/20260605093222.8555-2-m.lobanov%40rosa.ru
patch subject: [PATCH v3 2/2] xfs: shut down the filesystem on a failed mount
config: i386-allnoconfig-bpf (https://download.01.org/0day-ci/archive/20260605/202606051954.GRmELwA9-lkp@intel.com/config)
compiler: gcc-14 (Debian 14.2.0-19) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260605/202606051954.GRmELwA9-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202606051954.GRmELwA9-lkp@intel.com/

All warnings (new ones prefixed by >>):

   fs/xfs/xfs_icache.c: In function 'xfs_inodegc_inactivate':
>> fs/xfs/xfs_icache.c:1961:36: warning: suggest braces around empty body in an 'else' statement [-Wempty-body]
    1961 |                 xfs_qm_dqdetach(ip);
         |                                    ^


vim +/else +1961 fs/xfs/xfs_icache.c

  1933	
  1934	/*
  1935	 * Free all speculative preallocations and possibly even the inode itself.
  1936	 * This is the last chance to make changes to an otherwise unreferenced file
  1937	 * before incore reclamation happens.
  1938	 */
  1939	static int
  1940	xfs_inodegc_inactivate(
  1941		struct xfs_inode	*ip)
  1942	{
  1943		int			error = 0;
  1944	
  1945		trace_xfs_inode_inactivating(ip);
  1946	
  1947		/*
  1948		 * If the filesystem has been shut down - for example a mount that
  1949		 * failed after background inactivation was enabled - do not
  1950		 * inactivate the inode.  Inactivation modifies persistent metadata,
  1951		 * its transactions cannot complete on a shut down mount, and the
  1952		 * subsystems it relies on (e.g. quota, mp->m_quotainfo) may not be
  1953		 * set up.  Drop any attached dquots and make the inode reclaimable,
  1954		 * the same way xfs_inode_mark_reclaimable() does when it sends an
  1955		 * inode straight to reclaim.
  1956		 */
  1957		if (!xfs_is_shutdown(ip->i_mount))
  1958			error = xfs_inactive(ip);
  1959		else
  1960			/* Going straight to reclaim, so drop the dquots. */
> 1961			xfs_qm_dqdetach(ip);
  1962		xfs_inodegc_set_reclaimable(ip);
  1963		return error;
  1964	

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki