Linux XFS filesystem development
 help / color / mirror / Atom feed
From: caina <caina@uniontech.com>
To: hch@infradead.org
Cc: caina@uniontech.com, djwong@kernel.org, linux-xfs@vger.kernel.org
Subject: Re: [PATCH] xfs: clean up spelling and grammar errors in comments
Date: Wed, 17 Jun 2026 13:26:18 +0800	[thread overview]
Message-ID: <20260617052618.3702-1-caina@uniontech.com> (raw)
In-Reply-To: <ajFK3-Z7CpIx4Wh8@infradead.org>

On Tue, Jun 16, 2026 at 06:08:47AM -0700, Christoph Hellwig wrote:
> On Tue, Jun 16, 2026 at 10:09:12AM +0800, caina wrote:
> > -    * If we need to re-sort the free extents by length, do so so that we
> > +    * If we need to re-sort the free extents by length, do so that we
> >      * can put the records into the cntbt in the correct order.
> 
> This looks incorrect to me, but I'm not a native speaker.

Hi Christoph,

Thank you for the review.

I agree with you – the original "do so so that" is indeed correct here.
"do so" means "perform the re-sorting", and "so that" introduces the purpose.
Removing one "so" would make it ungrammatical. I will keep this line as "do so so that" in the next version.

> > @@ -342,7 +342,7 @@ xchk_btree_block_check_siblings(
> >     /*
> >      * Does the left & right sibling pointers match the adjacent
> >      * parent level pointers?
> 
> Should the does here be a do?

You are right – the subject "pointers" is plural, so the auxiliary verb should be "Do".
I will change it to "Do the left & right sibling pointers..." accordingly.

I will send a v2 patch with both fixes.

Please let me know if you have any other suggestions.

Thanks,
Caina

  reply	other threads:[~2026-06-17  5:27 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-16  2:09 [PATCH] xfs: clean up spelling and grammar errors in comments caina
2026-06-16 13:08 ` Christoph Hellwig
2026-06-17  5:26   ` caina [this message]
2026-06-17  5:50 ` [PATCH v2] " caina

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260617052618.3702-1-caina@uniontech.com \
    --to=caina@uniontech.com \
    --cc=djwong@kernel.org \
    --cc=hch@infradead.org \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox