Linux XFS filesystem development
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
Cc: Eric Sandeen <sandeen@sandeen.net>,
	Christoph Hellwig <hch@lst.de>, Zorro Lang <zlang@kernel.org>,
	"Darrick J. Wong" <djwong@kernel.org>,
	Lukas Herbolt <lukas@herbolt.com>,
	linux-xfs@vger.kernel.org, fstests@vger.kernel.org
Subject: Re: [PATCH 1/2] xfs/078: disable all concurrency scaling
Date: Fri, 19 Jun 2026 06:57:00 +0200	[thread overview]
Message-ID: <20260619045700.GA24871@lst.de> (raw)
In-Reply-To: <ajSgfekizOMFT0SB@shinmob>

On Fri, Jun 19, 2026 at 10:55:21AM +0900, Shin'ichiro Kawasaki wrote:
> On Jun 18, 2026 / 09:23, Eric Sandeen wrote:
> > On 6/18/26 8:54 AM, Eric Sandeen wrote:
> > > On 6/18/26 8:48 AM, Christoph Hellwig wrote:
> > >> Disable concurrency scaling to avoid mismatching output on systems with
> > >> a large CPU count.
> > >>
> > >> Reported-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
> > >> Signed-off-by: Christoph Hellwig <hch@lst.de>
> > > 
> > > I think this papers over what I still feel is a problem in mkfs.xfs
> > > behavior, but that's a different issue and making tests pass is good, so:
> > > 
> > > Reviewed-by: Eric Sandeen <sandeen@redhat.com>
> > 
> > Er, hang on - let me retract that. Lukas sent a series to address
> > this problem too, right, and one of the things he added in his series
> > is a helper to determine whether the concurrency options even exist,
> > so that this can continue to run on older xfsprogs, which seems like
> > a good idea, no?
> > 
> > https://git.kernel.org/pub/scm/fs/xfs/xfstests-dev.git/commit/?h=for-next&id=7f162f5bcf50fc32c7e3b432e7ff189571a3151f
> > 
> > which added _scratch_mkfs_xfs_supports_concurrency()
> 
> I agree, I think we can add the change below on top of this patch.
> Regardless of the change, I confirmed that this patch avoids the failure
> that I reported. Thanks!

Thanks, I'll add that.


  reply	other threads:[~2026-06-19  4:57 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-18 13:48 cpu scaling fixes Christoph Hellwig
2026-06-18 13:48 ` [PATCH 1/2] xfs/078: disable all concurrency scaling Christoph Hellwig
2026-06-18 13:54   ` Eric Sandeen
2026-06-18 14:23     ` Eric Sandeen
2026-06-19  1:55       ` Shin'ichiro Kawasaki
2026-06-19  4:57         ` Christoph Hellwig [this message]
2026-06-18 13:48 ` [PATCH 2/2] xfs/216: " Christoph Hellwig
2026-06-19  1:57   ` Shin'ichiro Kawasaki
  -- strict thread matches above, loose matches on Subject: below --
2026-06-19  5:09 cpu scaling fixes v2 Christoph Hellwig
2026-06-19  5:09 ` [PATCH 1/2] xfs/078: disable all concurrency scaling Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260619045700.GA24871@lst.de \
    --to=hch@lst.de \
    --cc=djwong@kernel.org \
    --cc=fstests@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    --cc=lukas@herbolt.com \
    --cc=sandeen@sandeen.net \
    --cc=shinichiro.kawasaki@wdc.com \
    --cc=zlang@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox