From: Christoph Hellwig <hch@lst.de>
To: Joanne Koong <joannelkoong@gmail.com>
Cc: Christoph Hellwig <hch@lst.de>,
willy@infradead.org, djwong@kernel.org,
linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org
Subject: Re: [RFC PATCH v1 1/3] iomap: add ->iomap_next() and iomap_process() helper
Date: Fri, 26 Jun 2026 07:12:03 +0200 [thread overview]
Message-ID: <20260626051203.GA9013@lst.de> (raw)
In-Reply-To: <CAJnrk1a3dY9r=jGVyTLT0k-J11wrdFc4sM6P94FBKwpi5TQTNw@mail.gmail.com>
On Thu, Jun 25, 2026 at 02:03:13PM -0700, Joanne Koong wrote:
> > As for the arguments: I don't really see much of a point in passing
> > the iomap/scrmap separately vs just the iter. Or am I missing something
> > here?
>
> It was meant to safeguard against a callback modifying iomap-internal
> non-mapping fields (iter->pos/len/status/iter_start_pos) but maybe
> this is unnecessary. I'll drop the 2 args and make it non-const.
As in my reply to Gao I missed the constness point. So I think keeping
the current version should be ok. I'm a little worried that we might
end up with something not beeing const in the end like the iter private
data, though.
next prev parent reply other threads:[~2026-06-26 5:12 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-25 2:47 [RFC PATCH v1 0/3] iomap: convert to in-iter ->iomap_next() model Joanne Koong
2026-06-25 2:47 ` [RFC PATCH v1 1/3] iomap: add ->iomap_next() and iomap_process() helper Joanne Koong
2026-06-25 12:56 ` Christoph Hellwig
2026-06-25 21:03 ` Joanne Koong
2026-06-26 5:12 ` Christoph Hellwig [this message]
2026-06-25 2:47 ` [RFC PATCH v1 2/3] xfs: convert read and buffered write iomap ops to ->iomap_next() Joanne Koong
2026-06-25 2:47 ` [RFC PATCH v1 3/3] xfs: example of devirtualizing buffered write iomap callbacks Joanne Koong
2026-06-25 13:00 ` Christoph Hellwig
2026-06-25 20:46 ` Joanne Koong
2026-06-25 3:25 ` [RFC PATCH v1 0/3] iomap: convert to in-iter ->iomap_next() model Gao Xiang
2026-06-25 3:37 ` Gao Xiang
2026-06-25 13:02 ` Christoph Hellwig
2026-06-25 13:21 ` Gao Xiang
2026-06-25 21:33 ` Joanne Koong
2026-06-26 2:22 ` Gao Xiang
2026-06-26 5:10 ` Christoph Hellwig
2026-06-26 5:35 ` Gao Xiang
2026-06-26 5:38 ` Christoph Hellwig
2026-06-25 13:03 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260626051203.GA9013@lst.de \
--to=hch@lst.de \
--cc=djwong@kernel.org \
--cc=joannelkoong@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox