From: "Darrick J. Wong" <djwong@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: Carlos Maiolino <cem@kernel.org>,
linux-xfs@vger.kernel.org, Carlos Maiolino <cmaiolino@redhat.com>
Subject: Re: [PATCH 2/6] xfs: also mark the buffer stale on verifier failure in xfs_buf_submit
Date: Fri, 26 Jun 2026 07:47:49 -0700 [thread overview]
Message-ID: <20260626144749.GQ6078@frogsfrogsfrogs> (raw)
In-Reply-To: <20260626062326.GA10546@lst.de>
On Fri, Jun 26, 2026 at 08:23:26AM +0200, Christoph Hellwig wrote:
> On Thu, Jun 25, 2026 at 11:21:46PM -0700, Darrick J. Wong wrote:
> > > ->verify_write is expected to set b_error when it fails (and yes,
> > > the API in that area is awful).
> >
> > Would you mind leaving a comment here, then?
> >
> > if ((bp->b_flags & XBF_WRITE) && !xfs_buf_verify_write(bp)) {
> > /* ->verify_write should have set b_error already */
> > xfs_force_shutdown(...);
> > goto out_ioerror;
> > }
>
> Sure.
With the comment added,
Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>
--D
next prev parent reply other threads:[~2026-06-26 14:47 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-25 13:58 xfs_buf_submit error handling fix v2 Christoph Hellwig
2026-06-25 13:58 ` [PATCH 1/6] xfs: open code xfs_buf_ioend_fail in xfs_buf_submit Christoph Hellwig
2026-06-25 13:58 ` [PATCH 2/6] xfs: also mark the buffer stale on verifier failure " Christoph Hellwig
2026-06-25 18:00 ` Darrick J. Wong
2026-06-26 4:35 ` Christoph Hellwig
2026-06-26 6:21 ` Darrick J. Wong
2026-06-26 6:23 ` Christoph Hellwig
2026-06-26 14:47 ` Darrick J. Wong [this message]
2026-06-25 13:58 ` [PATCH 3/6] xfs: improve the xfs_buf_ioend_fail calling convention Christoph Hellwig
2026-06-25 18:04 ` Darrick J. Wong
2026-06-25 13:58 ` [PATCH 4/6] xfs: remove xfs_buf_ioend Christoph Hellwig
2026-06-25 18:09 ` Darrick J. Wong
2026-06-25 13:58 ` [PATCH 5/6] xfs: fix handling of synchronous errors in xfs_buf_submit Christoph Hellwig
2026-06-25 18:13 ` Darrick J. Wong
2026-06-26 4:36 ` Christoph Hellwig
2026-06-25 13:58 ` [PATCH 6/6] xfs: simplify __xfs_buf_ioend Christoph Hellwig
2026-06-25 18:30 ` Darrick J. Wong
-- strict thread matches above, loose matches on Subject: below --
2026-06-22 7:29 xfs_buf_submit error handling fix Christoph Hellwig
2026-06-22 7:30 ` [PATCH 2/6] xfs: also mark the buffer stale on verifier failure in xfs_buf_submit Christoph Hellwig
2026-06-22 12:42 ` Carlos Maiolino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260626144749.GQ6078@frogsfrogsfrogs \
--to=djwong@kernel.org \
--cc=cem@kernel.org \
--cc=cmaiolino@redhat.com \
--cc=hch@lst.de \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox