From: Christoph Hellwig <hch@lst.de>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: aalbersh@kernel.org, linux-xfs@vger.kernel.org, hch@lst.de
Subject: Re: [PATCH 1/1] xfs_healer: fix getmntent race in weakhandle
Date: Tue, 30 Jun 2026 07:19:55 +0200 [thread overview]
Message-ID: <20260630051955.GC20888@lst.de> (raw)
In-Reply-To: <178278130366.858743.10151303158169061377.stgit@frogsfrogsfrogs>
On Mon, Jun 29, 2026 at 06:04:59PM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@kernel.org>
>
> Codex points out that getmntent() can't be used in threaded programs
> because it might employ hidden global static buffers.
Can't be used is a bit strong. It just can't be used by multiple
t─reads at the same time.
> GNU and musl libc
> provide a getmntent_r variant that requires the caller to establish the
> buffers, so let's use that.
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
prev parent reply other threads:[~2026-06-30 5:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-30 1:02 [PATCHSET 4/4] xfs_healer: codex-inspired bug fixes, part 3 Darrick J. Wong
2026-06-30 1:04 ` [PATCH 1/1] xfs_healer: fix getmntent race in weakhandle Darrick J. Wong
2026-06-30 5:19 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260630051955.GC20888@lst.de \
--to=hch@lst.de \
--cc=aalbersh@kernel.org \
--cc=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox