Re: [PATCH 2/4] xfs: lift setting __GFP_NOFAIL from xfs_buf_alloc_kmem to the caller

["Darrick J. Wong" <djwong@kernel.org>]

On Wed, Jul 01, 2026 at 11:31:27AM +0200, Carlos Maiolino wrote:
> On Mon, Jun 29, 2026 at 05:52:54PM -0700, Darrick J. Wong wrote:
> > On Wed, Jun 17, 2026 at 07:58:03AM +0200, Christoph Hellwig wrote:
> > > The current __GFP_NOFAIL setting is wrong in some cases.  Prepare
> > > for fixing that by giving control to the caller.
> > 
> > Simple enough...
> 
> /me interprets it as a RwB

Yeah.
Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>

--D

> 
> > 
> > > Signed-off-by: Christoph Hellwig <hch@lst.de>
> > > ---
> > >  fs/xfs/xfs_buf.c | 4 ++--
> > >  1 file changed, 2 insertions(+), 2 deletions(-)
> > > 
> > > diff --git a/fs/xfs/xfs_buf.c b/fs/xfs/xfs_buf.c
> > > index d3d44e3ff001..dce398337ad0 100644
> > > --- a/fs/xfs/xfs_buf.c
> > > +++ b/fs/xfs/xfs_buf.c
> > > @@ -145,7 +145,7 @@ xfs_buf_alloc_kmem(
> > >  	ASSERT(is_power_of_2(size));
> > >  	ASSERT(size < PAGE_SIZE);
> > >  
> > > -	bp->b_addr = kmalloc(size, gfp_mask | __GFP_NOFAIL);
> > > +	bp->b_addr = kmalloc(size, gfp_mask);
> > >  	if (!bp->b_addr)
> > >  		return -ENOMEM;
> > >  
> > > @@ -230,7 +230,7 @@ xfs_buf_alloc_backing_mem(
> > >  	 * smaller than PAGE_SIZE buffers used by XFS.
> > >  	 */
> > >  	if (size < PAGE_SIZE && is_power_of_2(size))
> > > -		return xfs_buf_alloc_kmem(bp, size, gfp_mask);
> > > +		return xfs_buf_alloc_kmem(bp, size, gfp_mask | __GFP_NOFAIL);
> > >  
> > >  	/*
> > >  	 * Don't bother with the retry loop for single PAGE allocations: vmalloc
> > > -- 
> > > 2.53.0
> > > 
> > > 
> >