Re: [PATCH v2 1/3] xfs: drop ASSERT(0) on unrecognized log item type

["Darrick J. Wong" <djwong@kernel.org>]

On Wed, Jul 01, 2026 at 08:38:31AM -0700, Weiming Shi wrote:
> The item type passed to ITEM_TYPE() comes from the on-disk log, so a
> fuzzed or crafted image can reach the "unrecognized type" path in
> xlog_recover_reorder_trans() and trip its ASSERT(0) on a
> CONFIG_XFS_DEBUG kernel.  The -EFSCORRUPTED return handles it fine; drop
> the assert.
> 
> Signed-off-by: Weiming Shi <bestswngs@gmail.com>

<nod> this is a validation of ondisk artifacts, so no assertions

Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>

--D

> ---
>  fs/xfs/xfs_log_recover.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/fs/xfs/xfs_log_recover.c b/fs/xfs/xfs_log_recover.c
> index 5f984bf5698a..a1b373c68f0e 100644
> --- a/fs/xfs/xfs_log_recover.c
> +++ b/fs/xfs/xfs_log_recover.c
> @@ -1912,7 +1912,6 @@ xlog_recover_reorder_trans(
>  			xfs_warn(log->l_mp,
>  				"%s: unrecognized type of log operation (%d)",
>  				__func__, ITEM_TYPE(item));
> -			ASSERT(0);
>  			/*
>  			 * return the remaining items back to the transaction
>  			 * item list so they can be freed in caller.
> -- 
> 2.43.0
> 
>