From: "Darrick J. Wong" <djwong@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: zlang@kernel.org, fstests@vger.kernel.org, linux-xfs@vger.kernel.org
Subject: Re: [PATCH] formalize and fix disabling the RT subvolume
Date: Thu, 2 Jul 2026 08:22:29 -0700 [thread overview]
Message-ID: <20260702152229.GC9381@frogsfrogsfrogs> (raw)
In-Reply-To: <20260702103323.GA6816@lst.de>
On Thu, Jul 02, 2026 at 12:33:23PM +0200, Christoph Hellwig wrote:
> On Wed, Jul 01, 2026 at 09:51:14AM -0700, Darrick J. Wong wrote:
> > Ahaha ok with this patch applied, the regressions I see in generic/441
> > and xfs/656 go away. generic/441 chokes because the scratch fs goes
> > down due to writeback error, so I assume it's ok to start excluding this
> > test.
>
> There also is a dedicated patch disabling them for zoned on the list":
>
> "common: skip data write EIO survival tests on fatal configs"
>
> from Yao Sang.
>
> > I'm guessing that the write failure takes down the filesystem, which is
> > why the subsequent xfs_io pread can't even open the file.
>
> Yes.
>
> >
> > Also the comment in xfs/655 and 656 doesn't make sense:
> >
> > # Disable the scratch rt device to avoid test failures relating to the
> > # rt bitmap consuming all the free space in our small data device.
> > unset SCRATCH_RTDEV
> >
> > We're creating a regular sized data device, so this shouldn't be an
> > issue.
>
> I think this has been copy and pasted with the unsetting of SCRATCH_RTDEV,
> as several tests have it..
Yes. I apologize for my contributions to the copy-pasta :(
--D
prev parent reply other threads:[~2026-07-02 15:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-30 11:35 [PATCH] formalize and fix disabling the RT subvolume Christoph Hellwig
2026-06-30 18:40 ` Darrick J. Wong
2026-07-01 10:54 ` Christoph Hellwig
2026-07-01 16:51 ` Darrick J. Wong
2026-07-02 10:33 ` Christoph Hellwig
2026-07-02 15:22 ` Darrick J. Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260702152229.GC9381@frogsfrogsfrogs \
--to=djwong@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=hch@lst.de \
--cc=linux-xfs@vger.kernel.org \
--cc=zlang@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox