From: "Darrick J. Wong" <djwong@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: cem@kernel.org, stable@vger.kernel.org, linux-xfs@vger.kernel.org
Subject: Re: [PATCH 1/6] xfs: don't replace the wrong part of the cow fork
Date: Thu, 9 Jul 2026 09:45:31 -0700 [thread overview]
Message-ID: <20260709164531.GE15228@frogsfrogsfrogs> (raw)
In-Reply-To: <20260709044738.GA15144@lst.de>
On Thu, Jul 09, 2026 at 06:47:38AM +0200, Christoph Hellwig wrote:
> On Wed, Jul 08, 2026 at 10:57:43AM -0700, Darrick J. Wong wrote:
> > On Wed, Jul 08, 2026 at 08:25:16AM -0700, Darrick J. Wong wrote:
> > > On Wed, Jul 08, 2026 at 11:12:20AM +0200, Christoph Hellwig wrote:
> > > > On Tue, Jul 07, 2026 at 10:03:24PM -0700, Darrick J. Wong wrote:
> > > > > static inline void
> > > > > xrep_cow_replace_mapping(
> > > > > + struct xfs_inode *ip,
> > > > > + struct xfs_iext_cursor *icur,
> > > > > + struct xfs_bmbt_irec *got,
> > > > > + struct xfs_bmbt_irec *rep)
> > > >
> > > > This looks like something that should sit in xfs_bmap.c (or at
> > > > least xfs_bmap_util.c) and not in random scrub code.
> >
> > To push back on this: there's only one user of this, why not keep it
> > local to the scrub code? AFAICT there's nowhere else in xfs that needs
> > to replace a subset of an existing cow fork mapping with another
> > mapping.
>
> Mostly so that all the code doing hairy operations on subsets of
> bmbt_irecs is kept together...
Ok. I'll do the move as a separate patch though.
--D
next prev parent reply other threads:[~2026-07-09 16:45 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-08 5:03 [PATCHSET] xfs: LLM-inspired bug fixes, part 1 Darrick J. Wong
2026-07-08 5:03 ` [PATCH 1/6] xfs: don't replace the wrong part of the cow fork Darrick J. Wong
2026-07-08 9:12 ` Christoph Hellwig
2026-07-08 15:25 ` Darrick J. Wong
2026-07-08 17:57 ` Darrick J. Wong
2026-07-09 4:47 ` Christoph Hellwig
2026-07-09 16:45 ` Darrick J. Wong [this message]
2026-07-08 5:03 ` [PATCH 2/6] xfs: don't wrap around quota ids in dqiterate Darrick J. Wong
2026-07-08 9:14 ` Christoph Hellwig
2026-07-08 5:03 ` [PATCH 3/6] xfs: use rtrefcount btree cursor in xchk_xref_is_rt_cow_staging Darrick J. Wong
2026-07-08 9:15 ` Christoph Hellwig
2026-07-08 5:04 ` [PATCH 4/6] xfs: use the rt version of the cow staging checker Darrick J. Wong
2026-07-08 9:16 ` Christoph Hellwig
2026-07-08 5:04 ` [PATCH 5/6] xfs: write the rg superblock when fixing it Darrick J. Wong
2026-07-13 6:41 ` Christoph Hellwig
2026-07-13 21:58 ` Darrick J. Wong
2026-07-14 5:20 ` Christoph Hellwig
2026-07-08 5:04 ` [PATCH 6/6] xfs: grab rtrmap btree when checking rgsuper Darrick J. Wong
2026-07-08 9:16 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260709164531.GE15228@frogsfrogsfrogs \
--to=djwong@kernel.org \
--cc=cem@kernel.org \
--cc=hch@lst.de \
--cc=linux-xfs@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox