From: Christoph Hellwig <hch@lst.de>
To: Johannes Thumshirn <johannes.thumshirn@wdc.com>
Cc: linux-xfs@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
Damien Le Moal <dlemoal@kernel.org>,
Carlos Maiolino <cem@kernel.org>
Subject: Re: [PATCH 1/3] xfs: add xfs_metadir_create_file helper
Date: Mon, 13 Jul 2026 08:51:24 +0200 [thread overview]
Message-ID: <20260713065124.GH29416@lst.de> (raw)
In-Reply-To: <20260712093317.782831-2-johannes.thumshirn@wdc.com>
On Sun, Jul 12, 2026 at 11:33:15AM +0200, Johannes Thumshirn wrote:
> Factor the metadata inode create/commit/cleanup lifecycle out of
> xfs_metadir_mkdir into a reusable helper that takes an optional callback
> to initialize the new inode, and convert xfs_metadir_mkdir to it.
This needs to be rebased on top of commit 45de375b2506 ("xfs: fix memory
leak in xfs_dqinode_metadir_create()"), which is already in mainline.
Without that revert the patch currently fails to apply.
Otherwise this looks good.
next prev parent reply other threads:[~2026-07-13 6:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-12 9:33 [PATCH 0/3] xfs: consolidate metadir creation code Johannes Thumshirn
2026-07-12 9:33 ` [PATCH 1/3] xfs: add xfs_metadir_create_file helper Johannes Thumshirn
2026-07-13 6:51 ` Christoph Hellwig [this message]
2026-07-12 9:33 ` [PATCH 2/3] xfs: create quota metadir inodes using xfs_metadir_create_file Johannes Thumshirn
2026-07-13 6:55 ` Christoph Hellwig
2026-07-12 9:33 ` [PATCH 3/3] xfs: create rtgroup " Johannes Thumshirn
2026-07-13 6:58 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260713065124.GH29416@lst.de \
--to=hch@lst.de \
--cc=cem@kernel.org \
--cc=dlemoal@kernel.org \
--cc=johannes.thumshirn@wdc.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox