Re: [PATCH v2 2/4] xfs: create quota metadir inodes using xfs_metadir_create_file

["Darrick J. Wong" <djwong@kernel.org>]

On Mon, Jul 13, 2026 at 02:42:48PM +0200, Johannes Thumshirn wrote:
> Now that we have xfs_metadir_create_file() use it in
> xfs_dqinode_metadir_create().
> 
> Reviewed-by: Christoph Hellwig <hch@lst.de>
> Signed-off-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>

Looks good to me,
Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>

--D

> ---
>  fs/xfs/libxfs/xfs_dquot_buf.c | 39 ++++++++++-------------------------
>  1 file changed, 11 insertions(+), 28 deletions(-)
> 
> diff --git a/fs/xfs/libxfs/xfs_dquot_buf.c b/fs/xfs/libxfs/xfs_dquot_buf.c
> index bbada0d3cc08..f960474bed3d 100644
> --- a/fs/xfs/libxfs/xfs_dquot_buf.c
> +++ b/fs/xfs/libxfs/xfs_dquot_buf.c
> @@ -416,6 +416,15 @@ xfs_dqinode_load(
>  	return 0;
>  }
>  
> +static int
> +xfs_dqinode_init(
> +	struct xfs_metadir_update	*upd,
> +	void				*priv)
> +{
> +	xfs_trans_log_inode(upd->tp, upd->ip, XFS_ILOG_CORE);
> +	return 0;
> +}
> +
>  /* Create a metadata directory quota inode. */
>  int
>  xfs_dqinode_metadir_create(
> @@ -428,35 +437,9 @@ xfs_dqinode_metadir_create(
>  		.metafile_type		= xfs_dqinode_metafile_type(type),
>  		.path			= xfs_dqinode_path(type),
>  	};
> -	int				error;
>  
> -	error = xfs_metadir_start_create(&upd);
> -	if (error)
> -		return error;
> -
> -	error = xfs_metadir_create(&upd, S_IFREG);
> -	if (error)
> -		goto out_cancel;
> -
> -	xfs_trans_log_inode(upd.tp, upd.ip, XFS_ILOG_CORE);
> -
> -	error = xfs_metadir_commit(&upd);
> -	if (error)
> -		goto out_irele;
> -
> -	xfs_finish_inode_setup(upd.ip);
> -	*ipp = upd.ip;
> -	return 0;
> -
> -out_cancel:
> -	xfs_metadir_cancel(&upd, error);
> -out_irele:
> -	/* Have to finish setting up the inode to ensure it's deleted. */
> -	if (upd.ip) {
> -		xfs_finish_inode_setup(upd.ip);
> -		xfs_irele(upd.ip);
> -	}
> -	return error;
> +	return xfs_metadir_create_file(&upd, S_IFREG, xfs_dqinode_init, NULL,
> +			ipp);
>  }
>  
>  #ifndef __KERNEL__
> -- 
> 2.54.0
> 
>