From: Andrey Albershteyn <aalbersh@kernel.org>
To: linux-xfs@vger.kernel.org, fsverity@lists.linux.dev,
linux-fsdevel@vger.kernel.org, ebiggers@kernel.org
Cc: Andrey Albershteyn <aalbersh@kernel.org>,
hch@lst.de, linux-ext4@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
linux-btrfs@vger.kernel.org, djwong@kernel.org
Subject: [PATCH v12 07/21] fs,fsverity: remove check for fsverity being enabled in setattr_prepare()
Date: Mon, 20 Jul 2026 11:03:35 +0200 [thread overview]
Message-ID: <20260720090410.3487990-8-aalbersh@kernel.org> (raw)
In-Reply-To: <20260720090410.3487990-1-aalbersh@kernel.org>
The check that fs-verity is available in the kernel is not necessary
here. Filesystems could have fsverity files even without fs-verity
module, then truncate will succeed. Previously, this would return
EOPNOTSUPP if verity is missing, but if it's not EPERM was returned
anyway.
Fixes: e9734653c523 ("fs,fsverity: reject size changes on fsverity files in setattr_prepare")
Signed-off-by: Andrey Albershteyn <aalbersh@kernel.org>
---
fs/attr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/attr.c b/fs/attr.c
index 4f437fabb7f0..71888ac903c2 100644
--- a/fs/attr.c
+++ b/fs/attr.c
@@ -176,7 +176,7 @@ int setattr_prepare(struct mnt_idmap *idmap, struct dentry *dentry,
* covered by the open-time check because sys_truncate() takes a
* path, not an open file.
*/
- if (IS_ENABLED(CONFIG_FS_VERITY) && IS_VERITY(inode))
+ if (IS_VERITY(inode))
return -EPERM;
error = inode_newsize_ok(inode, attr->ia_size);
--
2.54.0
next prev parent reply other threads:[~2026-07-20 9:05 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-20 9:03 [PATCH v12 00/21] fs-verity support for XFS with post EOF merkle tree Andrey Albershteyn
2026-07-20 9:03 ` [PATCH v12 01/21] fsverity: report validation errors through fserror to fsnotify Andrey Albershteyn
2026-07-20 9:03 ` [PATCH v12 02/21] fsverity: expose ensure_fsverity_info() Andrey Albershteyn
2026-07-20 9:03 ` [PATCH v12 03/21] fsverity: pass digest size and hash of the all-zeroes block to ->write Andrey Albershteyn
2026-07-21 2:58 ` David Sterba
2026-07-20 9:03 ` [PATCH v12 04/21] fsverity: hoist pagecache_read from f2fs/ext4 to fsverity Andrey Albershteyn
2026-07-20 9:03 ` [PATCH v12 05/21] fsverity: improve flushing performance of fsverity_fill_zerohash Andrey Albershteyn
2026-07-20 9:03 ` [PATCH v12 06/21] fsverity: don't allow setting DAX file attribute on fsverity files Andrey Albershteyn
2026-07-20 9:03 ` Andrey Albershteyn [this message]
2026-07-20 9:03 ` [PATCH v12 08/21] xfs: introduce fsverity on-disk changes Andrey Albershteyn
2026-07-20 9:03 ` [PATCH v12 09/21] xfs: don't allow to enable DAX on fs-verity sealed inode Andrey Albershteyn
2026-07-20 9:03 ` [PATCH v12 10/21] xfs: disable direct read path for fs-verity files Andrey Albershteyn
2026-07-20 9:03 ` [PATCH v12 11/21] xfs: don't report dio_mem_align and dio_offset_align for fsverity files Andrey Albershteyn
2026-07-20 9:03 ` [PATCH v12 12/21] xfs: handle fsverity I/O in write/read path Andrey Albershteyn
2026-07-20 9:03 ` [PATCH v12 13/21] xfs: use read ioend for fsverity data verification Andrey Albershteyn
2026-07-20 9:03 ` [PATCH v12 14/21] xfs: add fs-verity support Andrey Albershteyn
2026-07-20 9:03 ` [PATCH v12 15/21] xfs: remove unwritten extents after preallocations in fsverity metadata Andrey Albershteyn
2026-07-20 9:03 ` [PATCH v12 16/21] xfs: initialize fs-verity on file open Andrey Albershteyn
2026-07-20 9:03 ` [PATCH v12 17/21] xfs: add fs-verity ioctls Andrey Albershteyn
2026-07-20 9:03 ` [PATCH v12 18/21] xfs: advertise fs-verity being available on filesystem Andrey Albershteyn
2026-07-20 9:03 ` [PATCH v12 19/21] xfs: check and repair the verity inode flag state Andrey Albershteyn
2026-07-20 9:03 ` [PATCH v12 20/21] xfs: introduce health state for corrupted fsverity metadata Andrey Albershteyn
2026-07-20 9:03 ` [PATCH v12 21/21] xfs: enable ro-compat fs-verity flag Andrey Albershteyn
2026-07-21 8:46 ` [PATCH v12 00/21] fs-verity support for XFS with post EOF merkle tree Andrey Albershteyn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260720090410.3487990-8-aalbersh@kernel.org \
--to=aalbersh@kernel.org \
--cc=djwong@kernel.org \
--cc=ebiggers@kernel.org \
--cc=fsverity@lists.linux.dev \
--cc=hch@lst.de \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox