From: Christoph Hellwig <hch@lst.de>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: hch@lst.de, cem@kernel.org, stable@vger.kernel.org,
linux-xfs@vger.kernel.org
Subject: Re: [PATCH 4/9] xfs: load next_agino from the correct xfarray in xrep_iunlink_relink_prev
Date: Tue, 21 Jul 2026 06:47:10 +0200 [thread overview]
Message-ID: <20260721044710.GB6644@lst.de> (raw)
In-Reply-To: <178460419575.830862.6051379847990817321.stgit@frogsfrogsfrogs>
On Mon, Jul 20, 2026 at 08:25:51PM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@kernel.org>
>
> LOLLM notices that xrep_iunlink_relink_prev has the comment "set the
> forward pointer..." but then loads the value from the xfarray that
> stores pointers to the previous inode in the unlinked list. That's
> wrong, so fix the variable access.
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2026-07-21 4:47 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-21 3:23 [PATCHSET 2/2] xfs: LLM-inspired iunlink repair bug fixes Darrick J. Wong
2026-07-21 3:25 ` [PATCH 1/9] xfs: hoist per-bucket unlinked list check to helper Darrick J. Wong
2026-07-21 4:46 ` Christoph Hellwig
2026-07-21 3:25 ` [PATCH 2/9] xfs: don't livelock in scrub on a circular unlinked list Darrick J. Wong
2026-07-21 3:25 ` [PATCH 3/9] xfs: don't walk off the end of a null sc->sa.agi_bp in AGI repair Darrick J. Wong
2026-07-21 3:25 ` [PATCH 4/9] xfs: load next_agino from the correct xfarray in xrep_iunlink_relink_prev Darrick J. Wong
2026-07-21 4:47 ` Christoph Hellwig [this message]
2026-07-21 3:26 ` [PATCH 5/9] xfs: pass runtime errors from xrep_iunlink_mark_ondisk_rec up to callers Darrick J. Wong
2026-07-21 3:26 ` [PATCH 6/9] xfs: check xfarray iteration errors when committing unlinked inode lists Darrick J. Wong
2026-07-21 3:26 ` [PATCH 7/9] xfs: fix allocated inodes that show up in the unlinked list Darrick J. Wong
2026-07-21 3:26 ` [PATCH 8/9] xfs: fix another iunlink infinite loop bug in online fsck Darrick J. Wong
2026-07-21 4:47 ` Christoph Hellwig
2026-07-21 3:27 ` [PATCH 9/9] xfs: set the prev pointer when reinserting an inode on the unlinked list Darrick J. Wong
2026-07-21 6:03 ` Christoph Hellwig
2026-07-21 3:41 ` [RFC PATCH] xfs: test unlinked inode list checking and repair with loops Darrick J. Wong
2026-07-21 4:49 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260721044710.GB6644@lst.de \
--to=hch@lst.de \
--cc=cem@kernel.org \
--cc=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox